If that's the case, we should document the process in the release process documentation. Can you help update the wiki page?
- Sijie On Tue, Jan 21, 2020 at 1:23 PM Matteo Merli <matteo.me...@gmail.com> wrote: > In general, Homebrew will only accept updates to the formula once a > particular software version is already released. > We could certainly include it as a post-step in our release process, > to do after the official release announcement is done. > > > > -- > Matteo Merli > <matteo.me...@gmail.com> > > On Tue, Jan 21, 2020 at 11:08 AM Sijie Guo <guosi...@gmail.com> wrote: > > > > Thanks Dave. > > > > So the question will be - shall the release manager be responsible for > > updating the homebrew entry? If so, we need to include it in the release > > procedure. > > > > Thanks, > > Sijie > > > > On Mon, Jan 20, 2020 at 2:03 PM Dave Fisher <w...@apache.org> wrote: > > > > > Hi - > > > > > > I’ve played with Homebrew before and from the git log I can see that > > > Matteo created the initial version, but for the most part the Homebrew > > > community has maintained the script. > > > > > > Here is the current script: > > > > > > Formula/libpulsar.rb > > > class Libpulsar < Formula > > > desc "Apache Pulsar C++ library" > > > homepage "https://pulsar.apache.org/"; > > > url " > > > > https://www.apache.org/dyn/closer.cgi?path=pulsar/pulsar-2.4.2/apache-pulsar-2.4.2-src.tar.gz > > > " > > > sha256 > "4b543932db923aa135c4d54b9122bcbdfc67bd73de641f9fffbc9a4ddf3430ae" > > > revision 1 > > > > > > bottle do > > > cellar :any > > > sha256 > > > "13c37b77dee18f4bba454484b4426a6f3dad27f902e0793a56a6358897ab4f3f" => > > > :catalina > > > sha256 > > > "ff0090b77842ac6034c4a425438f8d5b401164da4bada7ac11c4963dcdaa3a28" => > > > :mojave > > > sha256 > > > "d73f612edf73a351ab7f90776c24670c4c77b85fd95e37999e863ff27daf89ef" => > > > :high_sierra > > > end > > > > > > depends_on "cmake" => :build > > > depends_on "pkg-config" => :build > > > depends_on "boost" > > > depends_on "openssl@1.1" > > > depends_on "protobuf" > > > depends_on "snappy" > > > depends_on "zstd" > > > > > > def install > > > cd "pulsar-client-cpp" do > > > system "cmake", ".", *std_cmake_args, > > > "-DBUILD_TESTS=OFF", > > > "-DBUILD_PYTHON_WRAPPER=OFF", > > > > "-DBoost_INCLUDE_DIRS=#{Formula["boost"].include}", > > > > > > "-DProtobuf_INCLUDE_DIR=#{Formula["protobuf"].include}", > > > > > > "-DProtobuf_LIBRARIES=#{Formula["protobuf"].lib}/libprotobuf.dylib" > > > system "make", "pulsarShared", "pulsarStatic" > > > system "make", "install" > > > end > > > end > > > > > > test do > > > (testpath/"test.cc").write <<~EOS > > > #include <pulsar/Client.h> > > > > > > int main (int argc, char **argv) { > > > pulsar::Client client("pulsar://localhost:6650"); > > > return 0; > > > } > > > EOS > > > system ENV.cxx, "test.cc", "-L#{lib}", "-lpulsar", "-o", "test" > > > system "./test" > > > end > > > end > > > > > > Here is the log w/o the bottling. > > > > > > % git log master -- Formula/libpulsar.rb > > > commit e4ed6752b0cab4c98ae72f81b2bd7160412bb938 > > > Author: FX Coudert <fxcoud...@gmail.com> > > > Date: Thu Dec 26 16:17:50 2019 +0100 > > > > > > libpulsar: revision for boost > > > > > > commit 07bd5db82526c43a0e5004f690f3afbda4b89c7c > > > Author: Matteo Merli <mme...@apache.org> > > > Date: Thu Dec 19 11:38:56 2019 -0800 > > > > > > libpulsar 2.4.2 > > > > > > Closes #48088. > > > > > > Signed-off-by: FX Coudert <fxcoud...@gmail.com> > > > > > > commit 3e6adba69f61da1b6fee5ba49199d299878f0db1 > > > Author: Austin Shalit <austinsha...@gmail.com> > > > Date: Wed Nov 27 23:32:07 2019 -0800 > > > > > > libpulsar: revision bump > > > > > > commit fc6e1f2d6179379740466631eb0dffd56b404f5c > > > Author: Rui Chen <rc...@meetup.com> > > > Date: Thu Oct 3 13:05:09 2019 -0400 > > > > > > libpulsar: revision for protobuf > > > > > > commit 11b3aa3dbe8a76716784cda9f351a28b49e9dfd0 > > > Author: Henry Fredrick Schreiner <henry.fredrick.schrei...@cern.ch> > > > Date: Mon Sep 2 20:47:07 2019 -0400 > > > > > > libpulsar 2.4.1: revision for boost 1.71.0 > > > > > > commit 0d14181d6cbdd044eeec9b78e1d4b7d766ff5f1d > > > Author: Henry Fredrick Schreiner <henry.fredrick.schrei...@cern.ch> > > > Date: Sun Sep 1 19:56:04 2019 -0400 > > > > > > libpulsar: Keep from linking to snappy > > > > > > Closes #43761. > > > > > > Signed-off-by: FX Coudert <fxcoud...@gmail.com> > > > > > > commit d9288916f84c02730c9ba800eb12550cb1b5b865 > > > Author: FX Coudert <fxcoud...@gmail.com> > > > Date: Thu Aug 29 10:28:00 2019 +0200 > > > > > > libpulsar: move to OpenSSL 1.1 > > > > > > commit 84d41c55af723989ccfd61161fc014c69f62da5c > > > Author: Matteo Merli <mme...@apache.org> > > > Date: Wed Aug 28 11:26:50 2019 -0700 > > > > > > libpulsar 2.4.0 > > > > > > Closes #43555. > > > > > > Signed-off-by: FX Coudert <fxcoud...@gmail.com> > > > > > > commit 7e24d72cbe366889612c2acc9d230d7263db4122 > > > Author: Chongyu Zhu <i...@lembacon.com> > > > Date: Wed May 29 15:24:44 2019 +0800 > > > > > > libpulsar: revision for protobuf > > > > > > commit 42a18870f92e42a787692c840d00cb5731ae6a5c > > > Author: FX Coudert <fxcoud...@gmail.com> > > > Date: Fri Apr 12 21:19:13 2019 +0200 > > > > > > libpulsar: revision and patch for boost > > > > > > commit 167f3474dd8ca620ab3e9d12513e88e499fe1ca2 > > > Author: Steven Peters <scpet...@openrobotics.org> > > > Date: Sat Jun 1 15:36:17 2019 -0700 > > > > > > libpulsar 2.3.2 > > > > > > Closes #40591. > > > > > > Signed-off-by: Steven Peters <scpet...@openrobotics.org> > > > > > > commit 1b3b8c15319503ff8a33e9627c7a46d5f8d2546f > > > Author: FX Coudert <fxcoud...@gmail.com> > > > Date: Mon Apr 15 17:40:36 2019 +0200 > > > > > > libpulsar 2.3.1 > > > > > > Closes #38947. > > > > > > Signed-off-by: FX Coudert <fxcoud...@gmail.com> > > > > > > commit 3c0b62cc0288f6d5dfb0ed9f682d6e245d1e3cfe > > > Author: Steven Peters <scpet...@openrobotics.org> > > > Date: Mon Mar 4 12:41:16 2019 -0800 > > > > > > libpulsar: revision for boost > > > > > > commit cac1d53d2254004b2082a2d501f772fcaf77b8c0 > > > Author: Chongyu Zhu <i...@lembacon.com> > > > Date: Sat Mar 2 23:50:28 2019 +0800 > > > > > > libpulsar: revision for protobuf > > > > > > commit fcc845573eef8564c7fac9ddba8a9e660b2d06f7 > > > Author: Matteo Merli <mme...@apache.org> > > > Date: Wed Feb 20 22:32:16 2019 -0800 > > > > > > libpulsar 2.3.0 > > > > > > Closes #37151. > > > > > > Signed-off-by: FX Coudert <fxcoud...@gmail.com> > > > > > > commit 24c06c4c49374136d484ef8a000b1c1626f2bf79 > > > Author: Viktor Szakats <com...@vszakats.net> > > > Date: Fri Jan 18 01:50:31 2019 +0000 > > > > > > libpulsar: use common/short form of apache url > > > > > > commit c2f34710ae2d378fbea076661016b87b31ce35af > > > Author: Matteo Merli <mme...@apache.org> > > > Date: Wed Oct 31 15:28:10 2018 -0700 > > > > > > libpulsar 2.2.1 (new formula) > > > > > > Closes #35809. > > > > > > Signed-off-by: FX Coudert <fxcoud...@gmail.com> > > > > > > > On Jan 20, 2020, at 1:19 PM, Sijie Guo <guosi...@gmail.com> wrote: > > > > > > > > Hi all, > > > > > > > > It is my first time to realize that there is a libpulsar entry in > > > homebrew. > > > > (https://github.com/apache/pulsar/issues/6091). Are Pulsar > committers > > > > responsible for updating this? Or homebrew team is updating that > entry? > > > > > > > > If the committers are responsible for updating it, it should have > been > > > > discussed in the mailing list before and we need to add an entry in > > > release > > > > doc about this. > > > > > > > > Thanks, > > > > Sijie > > > > > > >
