lhotari opened a new pull request #59:
URL: https://github.com/apache/pulsar-helm-chart/pull/59
### Changes
- using "exec" to run a command replaces the shell process with the executed
process
- this is required so that the process running in the container is able to
receive OS signals
- explained in
https://docs.docker.com/develop/develop-images/dockerfile_best-practices/
and https://docs.docker.com/engine/reference/builder/#entrypoint
- receiving SIGINT signal is required for graceful shutdown
This change might fix issues such as
https://github.com/apache/pulsar/issues/6603 . One expectation of this fix is
that graceful shutdown would allow Pulsar components such as a bookies to
deregistered from Zookeeper properly before shutdown.
### Motivation
Dockerfile best practices mention that "exec" should be used so that the
process running in a container can receive OS signals. This is explained in
https://docs.docker.com/develop/develop-images/dockerfile_best-practices/
and https://docs.docker.com/engine/reference/builder/#entrypoint .
Currently some issues while running Pulsar are caused by the lack of
graceful shutdown.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
