pinkavaj commented on a change in pull request #69:
URL: https://github.com/apache/pulsar-helm-chart/pull/69#discussion_r541904745



##########
File path: charts/pulsar/values.yaml
##########
@@ -963,6 +963,8 @@ pulsar_manager:
     hostname: ""
     path: "/"
 
+  ## If set use existing secret with specified name to set pulsar admin 
credentials.
+  existingSecret:

Review comment:
       Updated. It was my opinio the original name is the most used for this 
purpose and thus best fit into the helm charts ecosystem, but this of course 
might be only mi bias, sinc I does not have any strong support for this..




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to