dionjansen commented on a change in pull request #67:
URL: https://github.com/apache/pulsar-dotpulsar/pull/67#discussion_r552531082
##########
File path: src/DotPulsar/Internal/InactiveMessageAcksTracker.cs
##########
@@ -0,0 +1,30 @@
+namespace DotPulsar.Internal
+{
+ using Abstractions;
+ using DotPulsar.Abstractions;
+ using DotPulsar.Exceptions;
+ using Events;
+ using Microsoft.Extensions.ObjectPool;
+ using PulsarApi;
+ using System;
+ using System.Collections.Generic;
+ using System.Linq;
+ using System.Runtime.CompilerServices;
+ using System.Threading;
+ using System.Threading.Tasks;
+ using System.Diagnostics;
+
+ public sealed class InactiveMessageAcksTracker :
IMessageAcksTracker<MessageId>
+ {
+ public InactiveMessageAcksTracker() { }
+
+ public async Task StartTracker(IConsumer consumer, CancellationToken
cancellationToken)
+ {
+ await Task.Yield();
+ }
+
+ public MessageId Add(MessageId message) => message;
+ public MessageId Ack(MessageId message) => message;
+ public MessageId Nack(MessageId message) => message;
+ }
+}
Review comment:
I've cleaned up this implementation in
https://github.com/apache/pulsar-dotpulsar/pull/67/commits/0119ca95e00be46184f48ab847d5353cf7e6a74f
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
