On Fri, Mar 19, 2021 at 10:52 PM Enrico Olivelli <eolive...@gmail.com> wrote:
> Here it is > https://github.com/apache/pulsar/issues/9982 > > Here's a PR to address pull requests in draft status: https://github.com/apache/pulsar/pull/9994 Unfortunately, it's not possible to disable builds completely for PRs in draft status. The solution in the PR #9994 will fail-fast builds when the PR is in draft status. That should help achieve the goal of reducing resource consumption for PRs that are in draft status. The suggested solution in the GitHub community discussion seems to have the downside that a PR would be mergeable after a PR which is in draft status gets changed to "ready for review". This was reported in one of the comments: https://github.community/t/dont-run-actions-on-draft-pull-requests/16817/8 . "When the PR is switched from “draft” to “ready” the CI does not run again and the check is still marked as successful, so a user is able to merge the PR without having the check actually pass. " This problem might have been addressed with the "ready-for-review" event type filter. Since there isn't a guarantee about that, PR #9994 contains the fail-fast solutions which won't have the issue that PRs pass the checks accidentally after a draft PR is put to ready-for-review and someone immediately merges the PR. -Lari
