codelipenghui commented on a change in pull request #22:
URL: https://github.com/apache/pulsar-adapters/pull/22#discussion_r654194531



##########
File path: 
pulsar-client-kafka-compat/pulsar-client-kafka_0_8/src/test/java/org/apache/pulsar/client/kafka/test/KafkaProducerSimpleConsumerTest.java
##########
@@ -141,6 +141,7 @@ public void testPulsarKafkaProducerWithSerializer(int 
partitions) throws Excepti
             producer.send(message);
         }
         producer.close();
+        Thread.sleep(500);

Review comment:
       It's better to avoid using sleep in the test, could you please use 
Awaitility instead?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to