massakam commented on pull request #172:
URL:
https://github.com/apache/pulsar-client-node/pull/172#issuecomment-913294077
As a result of downgrading dtslint, the dtslint check now detects a large
number of errors, even though we have explicitly written "export".
```
Error: /pulsar-client-node/index.d.ts:21:18
ERROR: 21:18 strict-export-declare-modifiers All declarations in this
module are exported automatically. Prefer to explicitly write 'export' for
clarity. If you have a good reason not to export this declaration, add 'export
{}' to the module to shut off automatic exporting. See:
https://github.com/Microsoft/dtslint/blob/master/docs/strict-export-declare-modifiers.md
ERROR: 36:14 strict-export-declare-modifiers All declarations in this
module are exported automatically. Prefer to explicitly write 'export' for
clarity. If you have a good reason not to export this declaration, add 'export
{}' to the module to shut off automatic exporting. See:
https://github.com/Microsoft/dtslint/blob/master/docs/strict-export-declare-modifiers.md
ERROR: 44:18 strict-export-declare-modifiers All declarations in this
module are exported automatically. Prefer to explicitly write 'export' for
clarity. If you have a good reason not to export this declaration, add 'export
{}' to the module to shut off automatic exporting. See:
https://github.com/Microsoft/dtslint/blob/master/docs/strict-export-declare-modifiers.md
ERROR: 64:14 strict-export-declare-modifiers All declarations in this
module are exported automatically. Prefer to explicitly write 'export' for
clarity. If you have a good reason not to export this declaration, add 'export
{}' to the module to shut off automatic exporting. See:
https://github.com/Microsoft/dtslint/blob/master/docs/strict-export-declare-modifiers.md
ERROR: 73:18 strict-export-declare-modifiers All declarations in this
module are exported automatically. Prefer to explicitly write 'export' for
clarity. If you have a good reason not to export this declaration, add 'export
{}' to the module to shut off automatic exporting. See:
https://github.com/Microsoft/dtslint/blob/master/docs/strict-export-declare-modifiers.md
...
```
This time I want to give priority to passing the build, so skip this check:
https://github.com/apache/pulsar-client-node/pull/172/commits/51e00a742a98496610518eed13a10569f41db11d
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
