wangshu3000 commented on a change in pull request #183:
URL: https://github.com/apache/pulsar-helm-chart/pull/183#discussion_r777770205
##########
File path: charts/pulsar/templates/dashboard-ingress.yaml
##########
@@ -19,7 +19,11 @@
{{- if .Values.extra.dashboard }}
{{- if .Values.dashboard.ingress.enabled }}
+{{- if semverCompare "<1.19-0" .Capabilities.KubeVersion.GitVersion }}
Review comment:
@michaeljmarshall Thanks for the feedback.
Looks like they changed the doc. I saw this from some examples of helm repo.
Looks like it's been deprecated. The new value should be
Capabilities.KubeVersion.Version
There is one problem with .Capabilities.APIVersions.Has
When someone use helm template command. It'll lock the kubernetes version to
latest version in helm. So if they use new helm version 3.7+, there would
always has the new api version even already specify the old kubenetes version
in parameter. So the generated template yaml will have the new api version,
when applying those yaml files, they will be failed in old kubernetes cluster.
I think maybe we should change to KubeVersion.Version as the
KubeVersion.GitVersion has been deprecated.
Please let me know if this make sense.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
