Also, the file bin/pulsar present in the source tarball is not executable and we are missing the file "src/check-binary-license.sh"
If these problems are also in 2.9.2, then I don't consider them as blocker, otherwise there is a regression Enrico Il giorno lun 4 lug 2022 alle ore 13:06 Enrico Olivelli <eolive...@gmail.com> ha scritto: > > Mattison, > There are bad files, pom.xml.versionsBackup, inside the source tarball > > I believe that this is a problem > How did you build the release candidate ? > > the source tarball should not contain temporary Maven files > > Is this problem present in other Pulsar releases ? > > Enrico > > Il giorno mer 29 giu 2022 alle ore 16:50 mattison chao > <mattisonc...@apache.org> ha scritto: > > > > The docker images: > > > > https://hub.docker.com/layers/244373555/mattison/pulsar-all/2.9.3-rc-1/images/sha256-a7cb36d64817e73ee5dbac38d5435b4584bbbd8639d41449d21adff5138729d9?context=repo > > > > https://hub.docker.com/layers/243611358/mattison/pulsar/2.9.3-rc-1/images/sha256-79132930a35ec093ac428567bcbaf406baac9daa84009699ed00e7968bc84e48?context=repo > > > > On Tue, 28 Jun 2022 at 20:23, mattison chao <mattisonc...@apache.org> wrote: > > > > > I found one problem with this candidate. > > >> - When I import `pulsar-broker` and `managed-ledger` into my > > >> project, I found the project build failed with the following > > >> exceptions. > > > > > > > > > Hi, Hang. > > > > > > According to the release 2.10.1 vote email, it looks like this problem > > > gets solved and won't block the release. Right? > > > > > > Best, > > > Mattison > > > > > > On Tue, 28 Jun 2022 at 20:21, mattison chao <mattisonc...@apache.org> > > > wrote: > > > > > >> @mattison It's better to upload the image under your org first so that we > > >>> can verify the image > > >> > > >> > > >> Sure, I will do it later. > > >> > > >> Best, > > >> Mattison > > >> > > >> On Tue, 28 Jun 2022 at 15:57, Enrico Olivelli <eolive...@gmail.com> > > >> wrote: > > >> > > >>> Hang, > > >>> > > >>> Il giorno lun 27 giu 2022 alle ore 04:35 Hang Chen > > >>> <chenh...@apache.org> ha scritto: > > >>> > > > >>> > Hi Mattison, > > >>> > Thanks for your great work! > > >>> > > > >>> > I found one problem with this candidate. > > >>> > - When I import `pulsar-broker` and `managed-ledger` into my > > >>> > project, I found the project build failed with the following > > >>> > exceptions. > > >>> > > >>> You can fix this problem by importing the Pulsar BOM like we do in > > >>> Pulsar Adapters > > >>> https://github.com/apache/pulsar-adapters/blob/master/pom.xml#L163 > > >>> > > >>> Enrico > > >>> > > >>> > > > >>> > ``` > > >>> > [ERROR] Failed to execute goal on project test_pulsar_lib: Could not > > >>> > resolve dependencies for project > > >>> > org.example:test_pulsar_lib:jar:1.0-SNAPSHOT: Failed to collect > > >>> > dependencies for org.example:test_pulsar_lib:jar:1.0-SNAPSHOT: Could > > >>> > not resolve version conflict among > > >>> > [org.apache.pulsar:pulsar-broker:jar:2.9.3 -> > > >>> > org.apache.pulsar:pulsar-zookeeper-utils:jar:2.9.3 -> > > >>> > org.apache.bookkeeper:stream-storage-server:jar:4.14.5 -> > > >>> > org.apache.bookkeeper:stream-storage-java-client:jar:4.14.5 -> > > >>> > io.grpc:grpc-core:jar:1.42.1, > > >>> > org.apache.pulsar:pulsar-broker:jar:2.9.3 -> > > >>> > org.apache.pulsar:pulsar-zookeeper-utils:jar:2.9.3 -> > > >>> > org.apache.bookkeeper:stream-storage-server:jar:4.14.5 -> > > >>> > org.apache.bookkeeper:stream-storage-java-client:jar:4.14.5 -> > > >>> > io.grpc:grpc-testing:jar:1.42.1 -> > > >>> > io.grpc:grpc-core:jar:[1.42.1,1.42.1], > > >>> > org.apache.pulsar:pulsar-broker:jar:2.9.3 -> > > >>> > org.apache.pulsar:pulsar-zookeeper-utils:jar:2.9.3 -> > > >>> > io.grpc:grpc-all:jar:1.45.1 -> io.grpc:grpc-core:jar:[1.45.1,1.45.1], > > >>> > org.apache.pulsar:pulsar-broker:jar:2.9.3 -> > > >>> > org.apache.pulsar:pulsar-zookeeper-utils:jar:2.9.3 -> > > >>> > io.grpc:grpc-all:jar:1.45.1 -> io.grpc:grpc-grpclb:jar:1.45.1 -> > > >>> > io.grpc:grpc-core:jar:[1.45.1,1.45.1], > > >>> > org.apache.pulsar:pulsar-broker:jar:2.9.3 -> > > >>> > org.apache.pulsar:pulsar-zookeeper-utils:jar:2.9.3 -> > > >>> > io.grpc:grpc-all:jar:1.45.1 -> io.grpc:grpc-netty:jar:1.45.1 -> > > >>> > io.grpc:grpc-core:jar:[1.45.1,1.45.1], > > >>> > org.apache.pulsar:pulsar-broker:jar:2.9.3 -> > > >>> > org.apache.pulsar:pulsar-zookeeper-utils:jar:2.9.3 -> > > >>> > io.grpc:grpc-all:jar:1.45.1 -> io.grpc:grpc-rls:jar:1.45.1 -> > > >>> > io.grpc:grpc-core:jar:[1.45.1,1.45.1], > > >>> > org.apache.pulsar:pulsar-broker:jar:2.9.3 -> > > >>> > org.apache.pulsar:pulsar-zookeeper-utils:jar:2.9.3 -> > > >>> > io.grpc:grpc-all:jar:1.45.1 -> io.grpc:grpc-services:jar:1.45.1 -> > > >>> > io.grpc:grpc-core:jar:[1.45.1,1.45.1], > > >>> > org.apache.pulsar:pulsar-broker:jar:2.9.3 -> > > >>> > org.apache.pulsar:pulsar-zookeeper-utils:jar:2.9.3 -> > > >>> > io.grpc:grpc-all:jar:1.45.1 -> io.grpc:grpc-xds:jar:1.45.1 -> > > >>> > io.grpc:grpc-core:jar:1.45.1, > > >>> > org.apache.pulsar:pulsar-broker:jar:2.9.3 -> > > >>> > org.apache.pulsar:pulsar-zookeeper-utils:jar:2.9.3 -> > > >>> > io.grpc:grpc-all:jar:1.45.1 -> io.grpc:grpc-xds:jar:1.45.1 -> > > >>> > io.grpc:grpc-netty-shaded:jar:[1.45.1,1.45.1] -> > > >>> > io.grpc:grpc-core:jar:[1.45.1,1.45.1]] -> [Help 1] > > >>> > ``` > > >>> > > > >>> > There is a PR: https://github.com/apache/pulsar/pull/16109 removed > > >>> > pulsar-zookeeper-utils, which fixes this issue. But in branch 2.9, we > > >>> > still need this module, we can not cherry-pick this pr into > > >>> > branch-2.9. We can exclude the `io.grpc:grpc-core` in one dependency > > >>> > to fix this issue. > > >>> > > > >>> > Thanks, > > >>> > Hang > > >>> > > > >>> > PengHui Li <peng...@apache.org> 于2022年6月27日周一 09:51写道： > > >>> > > > > >>> > > +1 (binding) > > >>> > > > > >>> > > - verify gpg signatures > > >>> > > - run standalone > > >>> > > - pub/sub with pulsar-perf > > >>> > > - verify connector (Cassandra) > > >>> > > - verify stateful function > > >>> > > - build image and test internally for the integration tests (all the > > >>> tests > > >>> > > get passed) > > >>> > > > > >>> > > @mattison It's better to upload the image under your org first so > > >>> that we > > >>> > > can verify the image > > >>> > > > > >>> > > Thanks, > > >>> > > Penghui > > >>> > > > > >>> > > On Tue, Jun 21, 2022 at 9:24 AM mattison chao < > > >>> mattisonc...@apache.org> > > >>> > > wrote: > > >>> > > > > >>> > > > This is the first release candidate for Apache Pulsar, version > > >>> 2.9.3. > > >>> > > > > > >>> > > > It fixes the following issues: > > >>> > > > > > >>> > > > > > >>> https://github.com/apache/pulsar/pulls?q=is%3Amerged+is%3Apr+label%3Arelease%2F2.9.3+ > > >>> > > > > > >>> > > > *** Please download, test and vote on this release. This vote will > > >>> stay > > >>> > > > open > > >>> > > > for at least 72 hours *** > > >>> > > > > > >>> > > > Note that we are voting upon the source (tag), binaries are > > >>> provided for > > >>> > > > convenience. > > >>> > > > > > >>> > > > Source and binary files: > > >>> > > > > > >>> https://dist.apache.org/repos/dist/dev/pulsar/pulsar-2.9.3-candidate-1/ > > >>> > > > > > >>> > > > SHA-512 checksums: > > >>> > > > > > >>> > > > > > >>> > > > > > >>> cbc9efbb6b25704e306442b1f45ab7e309fb7c0476c380997b4541b66e4709baeff7c67107a5c68faefe40a32a559755df54a732b21b5c689612307e688f1bcb > > >>> > > > ./apache-pulsar-2.9.3-bin.tar.gz > > >>> > > > > > >>> > > > > > >>> > > > > > >>> 35795b824d0775ffcd426ff5b86858148fd55c3d465edc52f23aa938daefcc50dbffa962f26e03e6fa3a77a47c3b5f19f98e1a1fbd5a98f6fe6d800223a8ead8 > > >>> > > > ./apache-pulsar-2.9.3-src.tar.gz > > >>> > > > > > >>> > > > Maven staging repo: > > >>> > > > > > >>> https://repository.apache.org/content/repositories/orgapachepulsar-1158/ > > >>> > > > > > >>> > > > The tag to be voted upon: > > >>> > > > v2.9.3-candidate-1 (dd9a5f1f91651b634600f66c53dcc6ad855fb669) > > >>> > > > https://github.com/apache/pulsar/releases/tag/v2.9.3-candidate-1 > > >>> > > > > > >>> > > > Pulsar's KEYS file containing PGP keys we use to sign the release: > > >>> > > > https://dist.apache.org/repos/dist/dev/pulsar/KEYS > > >>> > > > > > >>> > > > Please download the source package, and follow the Release > > >>> Candidate > > >>> > > > Validation[1] > > >>> > > > to validate the release > > >>> > > > > > >>> > > > [1] > > >>> https://github.com/apache/pulsar/wiki/Release-Candidate-Validation > > >>> > > > > > >>> > > >>
