michaeljmarshall opened a new pull request, #138:
URL: https://github.com/apache/pulsar-site/pull/138

   The current replace.js script leads to malformed output because it converts 
proper links like 
`http://pulsar.apache.org/api/client/org/apache/pulsar/client/api/ConsumerConfiguration.html#setPriorityLevel-int-`
 into 
`http://pulsar.apache.orghttps://pulsar.apache.org/api/client/2.1.0-incubating/org/apache/pulsar/client/api/ConsumerConfiguration.html#setPriorityLevel-int-`.
 Instead, we should only replace links when they are properly at the start of a 
markdown file link, or when they start with a left paren.
   
   You can observe the current behavior and the changed behavior by running 
`node ./scripts/replace.js` in the `site2/website-next` directory then run `git 
diff` then grep for `orghttps`. After this change, there are not any malformed 
links.
   
   ```diff
   -`priorityLevel` | int | no | Define a 
[priority](http://pulsar.apache.org/api/client/org/apache/pulsar/client/api/ConsumerConfiguration.html#setPriorityLevel-int-)
 for the consumer
   +`priorityLevel` | int | no | Define a 
[priority](http://pulsar.apache.orghttps://pulsar.apache.org/api/client/2.1.0-incubating/org/apache/pulsar/client/api/ConsumerConfiguration.html#setPriorityLevel-int-)
 for the consumer
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to