This is an interesting result. It would be great if the download page after this release is made would indicate JDK versions.
Thanks! Dave Sent from my iPhone > On Aug 30, 2022, at 10:46 PM, Michael Marshall <mmarsh...@apache.org> wrote: > > Thank you both for verifying it on your end. After debugging this for > a way too long tonight, I discovered my mistake was using Java 11 > instead of Java 8. It didn't occur to me that the different versions > could/would result in a different set of dependencies. > > When I use Java 8, this command passes now: src/check-binary-license > distribution/server/target/apache-pulsar-2.7.5-bin.tar.gz. I plan to > finish my release validation tomorrow. > > Thanks! > Michael > > > >> On Tue, Aug 30, 2022 at 4:21 AM Anon Hxy <anonhx...@gmail.com> wrote: >> >> Hi Michael, >> >> I also couldn't reproduce it with the same steps Haiting provided. >> >> Here is my local environment info with `mvn -v` >> >> Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) >> Maven home: /Users/didi/Documents/apache-maven-3.6.3 >> Java version: 1.8.0_291, vendor: Oracle Corporation, runtime: >> /Library/Java/JavaVirtualMachines/jdk1.8.0_291.jdk/Contents/Home/jre >> Default locale: zh_CN, platform encoding: UTF-8 >> OS name: "mac os x", version: "10.16", arch: "x86_64", family: "mac" >> >> Thanks, >> Xiaoyu Hou >> >> >> Haiting Jiang <jianghait...@gmail.com> 于2022年8月30日周二 15:23写道： >> >>> Hi Michael, >>> Thanks for your verification. >>> >>> I tried to recreate the issue, but I can't reproduce this. >>> Here is my steps: >>> - wget >>> >>> https://dist.apache.org/repos/dist/dev/pulsar/pulsar-2.7.5-candidate-3/apache-pulsar-2.7.5-src.tar.gz >>> - tar -xvf apache-pulsar-2.7.5-src.tar.gz >>> - cd apache-pulsar-2.7.5 >>> - mvn clean install -DskipTests >>> - src/check-binary-license >>> distribution/server/target/apache-pulsar-2.7.5-bin.tar.gz >>> >>> And nothing appears in `check-binary-license` output. >>> >>> Here is my local environment info with `mvn -v` >>> >>> Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; >>> 2019-04-05T03:00:29+08:00) >>> Maven home: /Users/jason/apache-maven-3.6.1 >>> Java version: 1.8.0_291, vendor: Oracle Corporation, runtime: >>> /Library/Java/JavaVirtualMachines/jdk1.8.0_291.jdk/Contents/Home/jre >>> Default locale: en_CN, platform encoding: UTF-8 >>> OS name: "mac os x", version: "10.15.7", arch: "x86_64", family: "mac" >>> >>> Please check the settings again and I also will ask others to help verify >>> the issue you mention. >>> >>> Thanks, >>> Haiting >>> >>> >>> On Tue, Aug 30, 2022 at 12:37 PM Michael Marshall <mmarsh...@apache.org> >>> wrote: >>> >>>> When I build from the source (both for the git tag >>>> `v2.7.5-candidate-3` and the extracted src tarball >>>> `apache-pulsar-2.7.5-src.tar.gz`), I am getting an error when I run >>>> the license check: >>>> >>>> ``` >>>> $ src/check-binary-license >>>> distribution/server/target/apache-pulsar-2.7.5-bin.tar.gz >>>> com.sun.activation-jakarta.activation-1.2.2.jar unaccounted for in >>> LICENSE >>>> jakarta.activation-jakarta.activation-api-1.2.2.jar unaccounted for in >>>> LICENSE >>>> jakarta.xml.bind-jakarta.xml.bind-api-2.3.3.jar unaccounted for in >>> LICENSE >>>> jakarta.activation-jakarta.activation-api-1.2.1.jar mentioned in >>>> LICENSE, but not bundled >>>> jakarta.xml.bind-jakarta.xml.bind-api-2.3.2.jar mentioned in LICENSE, >>>> but not bundled >>>> jakarta.activation-1.2.2.jar unaccounted for in lib/presto/LICENSE >>>> jakarta.activation-1.2.2.jar unaccounted for in lib/presto/LICENSE >>>> jakarta.activation-api-1.2.2.jar unaccounted for in lib/presto/LICENSE >>>> jakarta.xml.bind-api-2.3.3.jar unaccounted for in lib/presto/LICENSE >>>> jetty-alpn-java-client-9.4.27.v20200227.jar unaccounted for in >>>> lib/presto/LICENSE >>>> >>>> It looks like there are issues with the LICENSE/NOTICE. >>>> ``` >>>> >>>> My understanding is that the missing license attributions are a >>>> blocker for the release candidate. Is someone able to confirm that >>>> this is an issue? I ran this command as the release process doc >>>> indicates here [0]. >>>> >>>> Before finding the above issue, I successfully ran the following checks: >>>> - Verified checksums and signatures on all 45 artifacts >>>> - Compiled from source (apache-pulsar-2.7.5-src.tar.gz) using `mvn >>>> clean install -DskipTest` >>>> - Ran `mvn apache-rat:check` successfully >>>> >>>> Thanks, >>>> Michael >>>> >>>> [0] >>>> >>> https://github.com/apache/pulsar/blob/db16e440622c3eed225c4da5380c70b16a583787/wiki/release/release-process.md#3-build-and-inspect-the-artifacts >>>> >>>> On Mon, Aug 29, 2022 at 9:20 AM Nicolò Boschi <boschi1...@gmail.com> >>>> wrote: >>>>> >>>>> +1 (non binding) >>>>> >>>>> Checks: >>>>> >>>>> - Checksum and signatures >>>>> >>>>> - Apache Rat check passes >>>>> >>>>> - Compile from source >>>>> >>>>> - Run Pulsar standalone and produce-consume from CLI >>>>> >>>>> >>>>> Nicolò Boschi >>>>> >>>>> >>>>> Il giorno sab 27 ago 2022 alle ore 17:12 Qiang Huang < >>>>> qiang.huang1...@gmail.com> ha scritto: >>>>> >>>>>> +1(non-binding) >>>>>> - Checked signatures/checksums >>>>>> - Checked the license headers >>>>>> - Ran the standalone >>>>>> - Validate Connectors >>>>>> - Validate Pub/Sub and Java Functions >>>>>> - Validate Stateful Functions >>>>>> >>>>>> Haiting Jiang <jianghait...@gmail.com> 于2022年8月27日周六 06:40写道： >>>>>> >>>>>>> This is the third release candidate for Apache Pulsar, version >>> 2.7.5. >>>>>>> >>>>>>> It fixes the following issues: >>>>>>> >>> https://github.com/apache/pulsar/compare/v2.7.4...v2.7.5-candidate-3 >>>>>>> >>>>>>> *** Please download, test and vote on this release. This vote will >>>> stay >>>>>>> open >>>>>>> for at least 72 hours *** >>>>>>> >>>>>>> Note that we are voting upon the source (tag), binaries are >>> provided >>>> for >>>>>>> convenience. >>>>>>> >>>>>>> Source and binary files: >>>>>>> >>>> https://dist.apache.org/repos/dist/dev/pulsar/pulsar-2.7.5-candidate-3/ >>>>>>> >>>>>>> SHA-512 checksums: >>>>>>> >>>>>>> >>>>>>> >>>>>> >>>> >>> 6aa74cb742c411edd40de2199eb70d774d0ce8cb7dbfc2ce33fce7e87949aafa73f93a1e154261b58a1df4ad10160bf43fc5a93b1aa9a0466fcf2a3ba1a6e385 >>>>>>> apache-pulsar-2.7.5-bin.tar.gz >>>>>>> >>>>>>> >>>>>> >>>> >>> facb1698e394b5428a0b9b6d71b891013f3c5b473cf72dd68a75ca729800710f2c6c476b1c47f7804c1b1c0941f79a6a9f334c7c703f66f6bac8f399386c5ad6 >>>>>>> apache-pulsar-2.7.5-src.tar.gz >>>>>>> >>>>>>> Maven staging repo: >>>>>>> >>>> https://repository.apache.org/content/repositories/orgapachepulsar-1172/ >>>>>>> >>>>>>> The tag to be voted upon: >>>>>>> v2.7.5-candidate-3 (8eae5b8d572861e49c40d456b1f3cbc5d414afe1) >>>>>>> https://github.com/apache/pulsar/releases/tag/v2.7.5-candidate-3 >>>>>>> >>>>>>> Docker images: >>>>>>> >>>>>>> >>>>>>> >>>>>> >>>> >>> https://hub.docker.com/layers/jason918/pulsar/2.7.5/images/sha256-ec77603bd943f1a56065d155428d6edccb2bf2ec57fafab8112c4b73c7bfcb6e >>>>>>> >>>>>>> >>>>>> >>>> >>> https://hub.docker.com/layers/pulsar-all/jason918/pulsar-all/latest/images/sha256-0792a0ec75ecbc16c9a42af127a68b3dea2331be3f2f0599f5fb1f4cd78def25 >>>>>>> >>>>>>> Pulsar's KEYS file containing PGP keys we use to sign the release: >>>>>>> https://dist.apache.org/repos/dist/dev/pulsar/KEYS >>>>>>> >>>>>>> Please download the source package, and follow the README to build >>>>>>> and run the Pulsar standalone service. >>>>>>> >>>>>>> Thanks, >>>>>>> Haiting >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> BR, >>>>>> Qiang Huang >>>>>> >>>> >>>
