-- Matteo Merli <[email protected]> On Tue, Oct 11, 2022 at 7:35 PM Michael Marshall <[email protected]> wrote: > > I am getting an error when building from the downloaded source tarball > while following the instructions in the README. I get this error: > > $ ./docker-build.sh > fatal: not a git repository (or any of the parent directories): .git
docker-build.sh was a script created for CI in the old repo. It doesn't make sense for someone to compile inside Docker because the resulting library will most likely not be usable in their environment. Honestly, I don't know why it was ever documented in the README. Since we're not using it anymore in CI, we should remove it. I created a PR https://github.com/apache/pulsar-client-cpp/pull/46 > I am not certain, but it seems like we need to end this vote and fix > the build script so that users can build from source. Let me know what > you think. I would suspect that not many people would be trying to compile with the docker script and the other instructions to build from source should all be working already. In any case, we can remove them and create a new candidate.
