Hi, Xiangying: I have to change the PIP when `MessageIdImpl compareTo(BatchMessageIdImpl)` or `BatchMessageIdImpl compareTo(MessageIdImpl)` will throw an exception.
Thanks, Bo Xiangying Meng <xiangy...@apache.org> 于2022年12月19日周一 08:13写道： > > Hi Bo > I am confused about this proposal. > Why do there exist MessageID and BatchMessageID with the same ledgerID, > entryID, and partitionIndex? > And why it is right that the MessageID is always bigger than the > BatchMessageID? > I also leave some comments below on the issue. Could you help answer it? > > Thanks, > Xiangying > > On Mon, Dec 19, 2022 at 2:54 AM Yubiao Feng > <yubiao.f...@streamnative.io.invalid> wrote: > > > Hi Bo > > > > > Disadvantages of the current compareTo() implementation: Many users may > > use this method incorrectly, resulting in seek, ack, or resetCursor use > > incorrect MessageId, which has the risk of losing messages, because they > > will use a larger messageId to seek, ack etc. > > > > I'm a little curious why the message will lose, could you explain it? > > > > Thanks > > Yubiao > > > > On Fri, Dec 16, 2022 at 5:31 PM 丛搏 <bog...@apache.org> wrote: > > > > > Hi, pulsar community: > > > > > > I start a PIP about modifying MessageIdImpl and BatchMessageIdImpl > > > compareTo(MessageId o) method > > > > > > original discussion thread: > > > https://lists.apache.org/thread/8n3oyk2hdsskkotnj4lnlvfnndctpqbg > > > > > > PIP: https://github.com/apache/pulsar/issues/18957 > > > > > > Thanks, > > > Bo > > > > >
