Hi Lari. Thanks for feedback. It is necessary to reduce the size of dependency which has been added in high level design of the pip.
> Would it be possible to cover this important aspect as part of PIP-393 > before taking it to voting? Do you means that we fix this problem as part of the implementation of PIP-393? For example, [improve][pip] PIP-393: Improve performance of Negative Acknowledgement - PART 1 [improve][pip] PIP-393: Improve performance of Negative Acknowledgement - PART 2 part one for original implementation, part two for shading dependency. I am not specialized in shading dependency of the pulsar, it will be great if you can help to accomplish this pip together. Thanks. Wenzhi Feng(thetumbled) On 2024/11/26 09:01:59 Lari Hotari wrote: > Great work, Wenzhi. > > The PIP-393 document should include the high level plan of avoiding to > increase the size of the Pulsar client by the size of fastutil jar > file. The fastutil jar file is very large, 23MB. We use only a few > classes of fastutil. There's fastutil-core library which is smaller, > about ≅6MB. However, that is also relatively large and using > fastutil-core will introduce another problem on the broker side since > there's already fastutil jar which also includes fastutil-core jar > classes. It's necessary to design a proper shading solution as part of > this PIP design and implementation. > > Would it be possible to cover this important aspect as part of PIP-393 > before taking it to voting? > > -Lari > > On Fri, 15 Nov 2024 at 10:47, thetumbled <wof...@qq.com.invalid> wrote: > > > > Hi, Pulsar Community. > > I open a new PIP to fix several issues with negative ack feature. Most > > importantly, the memory occupation is less than 1% of the original > > implementation, which make it practical to work in the production > > enviroment. > > Some experiment data is listed in the PR, you can also verify the > > improvement with the test code i show. > > link: https://github.com/apache/pulsar/pull/23601 > > > > Thanks, > > Wenzhi Feng(thetumbled) >
