GitHub user rdhabalia opened a pull request:
https://github.com/apache/incubator-pulsar/pull/533
exclude license for athenz-test-conf file
### Motivation
Athenz-test was failing due to invalid test-conf file under test-resource.
Adding license was making file invalid for parsing.
```
Running
org.apache.pulsar.broker.authentication.AuthenticationProviderAthenzTest
com.fasterxml.jackson.core.JsonParseException: Unexpected character ('#'
(code 35)): expected a valid value (number, String, array, object, 'true',
'false' or 'null')
at [Source: [B@7c1e2a9e; line: 1, column: 2]
at
com.fasterxml.jackson.core.JsonParser._constructError(JsonParser.java:1419)
at
com.fasterxml.jackson.core.base.ParserMinimalBase._reportError(ParserMinimalBase.java:508)
at
com.fasterxml.jackson.core.base.ParserMinimalBase._reportUnexpectedChar(ParserMinimalBase.java:437)
at
com.fasterxml.jackson.core.json.UTF8StreamJsonParser._handleUnexpectedValue(UTF8StreamJsonParser.java:2363)
at
com.fasterxml.jackson.core.json.UTF8StreamJsonParser._nextTokenNotInObject(UTF8StreamJsonParser.java:794)
at
com.fasterxml.jackson.core.json.UTF8StreamJsonParser.nextToken(UTF8StreamJsonParser.java:690)
at
com.fasterxml.jackson.databind.ObjectReader._initForReading(ObjectReader.java:1346)
at
com.fasterxml.jackson.databind.ObjectReader._bindAndClose(ObjectReader.java:1252)
at
com.fasterxml.jackson.databind.ObjectReader.readValue(ObjectReader.java:912)
at com.yahoo.rdl.JSON.fromBytes(JSON.java:56)
at
com.yahoo.athenz.zpe.pkey.file.FilePublicKeyStore.init(FilePublicKeyStore.java:56)
at
com.yahoo.athenz.zpe.pkey.file.FilePublicKeyStoreFactory.create(FilePublicKeyStoreFactory.java:26)
at com.yahoo.athenz.zpe.AuthZpeClient.<clinit>(AuthZpeClient.java:147)
at
org.apache.pulsar.broker.authentication.AuthenticationProviderAthenz.authenticate(AuthenticationProviderAthenz.java:97)
at
org.apache.pulsar.broker.authentication.AuthenticationProviderAthenzTest.testAuthenticateSignedToken(AuthenticationProviderAthenzTest.java:79)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:84)
at org.testng.internal.Invoker.invokeMethod(Invoker.java:714)
at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:901)
at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1231)
at
org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:127)
at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:111)
at org.testng.TestRunner.privateRun(TestRunner.java:767)
at org.testng.TestRunner.run(TestRunner.java:617)
at org.testng.SuiteRunner.runTest(SuiteRunner.java:334)
at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:329)
at org.testng.SuiteRunner.privateRun(SuiteRunner.java:291)
at org.testng.SuiteRunner.run(SuiteRunner.java:240)
at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52)
at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:86)
at org.testng.TestNG.runSuitesSequentially(TestNG.java:1224)
at org.testng.TestNG.runSuitesLocally(TestNG.java:1149)
at org.testng.TestNG.run(TestNG.java:1057)
at
org.apache.maven.surefire.testng.TestNGExecutor.run(TestNGExecutor.java:132)
at
org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.executeSingleClass(TestNGDirectoryTestSuite.java:112)
at
org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.execute(TestNGDirectoryTestSuite.java:99)
at
org.apache.maven.surefire.testng.TestNGProvider.invoke(TestNGProvider.java:147)
at
org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:290)
at
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:242)
at
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:121)
Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.564 sec
<<< FAILURE! - in
org.apache.pulsar.broker.authentication.AuthenticationProviderAthenzTest
testAuthenticateSignedToken(org.apache.pulsar.broker.authentication.AuthenticationProviderAthenzTest)
Time elapsed: 0.939 sec <<< FAILURE!
javax.naming.AuthenticationException: Unable to retrieve ZTS Public Key
at
org.apache.pulsar.broker.authentication.AuthenticationProviderAthenzTest.testAuthenticateSignedToken(AuthenticationProviderAthenzTest.java:79)
Results :
Failed tests:
AuthenticationProviderAthenzTest.testAuthenticateSignedToken:79 û
Authentication
```
### Modifications
- Exclude license headers for athenz resource file.
- rename file as file extension ".conf" [must requires a
header](https://github.com/apache/incubator-pulsar/blob/master/pom.xml#L580)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rdhabalia/pulsar athenz
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-pulsar/pull/533.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #533
----
commit 2b437bca7de433ab2381be6420746e3fa251de2c
Author: rdhabalia <[email protected]>
Date: 2017-06-27T19:19:03Z
exclude license for athenz-test-conf file
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---