merlimat commented on a change in pull request #548: PIP-1 - Introduce Pulsar
proxy component
URL: https://github.com/apache/incubator-pulsar/pull/548#discussion_r126525324
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/BinaryProtoLookupService.java
##########
@@ -59,7 +62,7 @@ public BinaryProtoLookupService(PulsarClientImpl client,
String serviceUrl, bool
* @param destination: topic-name
* @return broker-socket-address that serves given topic
*/
- public CompletableFuture<InetSocketAddress> getBroker(DestinationName
destination) {
+ public CompletableFuture<Pair<InetSocketAddress, InetSocketAddress>>
getBroker(DestinationName destination) {
Review comment:
In this case it would be the same number of object allocations, either a
`Pair<>` or the `InetSocketAddress[]`. No differences, except `Pair` conveys
better the fact that 2 addresses are going to be there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
