merlimat commented on a change in pull request #559: Add empty check for
subscription name
URL: https://github.com/apache/incubator-pulsar/pull/559#discussion_r127007922
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
##########
@@ -349,6 +350,12 @@ public void removeProducer(Producer producer) {
final CompletableFuture<Consumer> future = new CompletableFuture<>();
+ if (isBlank(subscriptionName)) {
+ log.warn("[{}] Empty subscription name", topic);
Review comment:
Could we leave this at debug level in the broker logs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
