merlimat commented on a change in pull request #561: Fix: CPP release
baseCommand after serializing it
URL: https://github.com/apache/incubator-pulsar/pull/561#discussion_r127106664
##########
File path: pulsar-client-cpp/lib/ClientConnection.cc
##########
@@ -941,13 +941,15 @@ ClientConnection::newConsumerStats(uint64_t consumerId,
uint64_t requestId) {
void ClientConnection::newTopicLookup(const std::string& destinationName, bool
authoritative,
const uint64_t requestId,
LookupDataResultPromisePtr promise) {
+ Lock lock(mutex_);
Review comment:
`outgoingCmd_` is being accessed outside of the lock in few places. eg: line
937
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
