rdhabalia commented on a change in pull request #577: CPP add receiveAsync API URL: https://github.com/apache/incubator-pulsar/pull/577#discussion_r128112264
########## File path: pulsar-client-cpp/include/pulsar/ConsumerConfiguration.h ########## @@ -33,6 +33,7 @@ class PulsarWrapper; /// Callback definition for non-data operation typedef boost::function<void(Result result)> ResultCallback; +typedef boost::function<void(const Message& msg)> ReceiveCallback; Review comment: however, we should immediately fail the callback if consumer is closing or already closed. so, I have added the result into the callback. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
