rdhabalia commented on a change in pull request #634: PIP-3 : Introduce 
message-dispatch rate limiting
URL: https://github.com/apache/incubator-pulsar/pull/634#discussion_r132027569
 
 

 ##########
 File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java
 ##########
 @@ -245,6 +245,19 @@ protected Policies getNamespacePolicies(String property, 
String cluster, String
         }
     }
 
+    protected LocalPolicies getNamespaceLocalPolicies(String property, String 
cluster, String namespace) {
 
 Review comment:
   > Shouldn't we configuring the throttling policies on the global zk?
   
   Actually, every cluster has different traffic for the namespace and we may 
want to control enabling or throttling-limit per cluster level. Therefore, kept 
it in local-policies and not in global-zk.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to