merlimat commented on a change in pull request #634: PIP-3 : Introduce 
message-dispatch rate limiting
URL: https://github.com/apache/incubator-pulsar/pull/634#discussion_r132033540
 
 

 ##########
 File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java
 ##########
 @@ -245,6 +245,19 @@ protected Policies getNamespacePolicies(String property, 
String cluster, String
         }
     }
 
+    protected LocalPolicies getNamespaceLocalPolicies(String property, String 
cluster, String namespace) {
 
 Review comment:
   That's fine, but it can be quite confusing for a user given that other 
methods are changing the settings globally. 
   
   I think it could either be explicitely set for a particular cluster, or for 
all the clusters. In order to clarify the scope. Eg: 
   
   ```json
   {
    "rateLimit" : { 
        "dispatchRatePerTopicInMsg" : 1000.0,
         "dispatchRatePerTopicInBytes" : 1000000.0,
        "clusters" : {
             "small-cluster" : {
                  "dispatchRatePerTopicInMsg" : 10.0,
                  "dispatchRatePerTopicInBytes" : 1000.0,
             },
            "large-cluster" : {
                  "dispatchRatePerTopicInMsg" : 1000000.0,
                  "dispatchRatePerTopicInBytes" : 1000000000.0,
             }
        } 
    }
   }
   ```
   
   The advantage is that you can also see all the limit in a single place. 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to