merlimat opened a new pull request #673: Fix #657: Use exceptions instead of 
assert() to do runtime parameter ?
   ### Motivation
   Since we use the Release profile to compile in the `pulsar-master` Jenkins 
build, CMake is passing the `-DNDEBUG` macro which remove the assertions.
   The ProducerConfiguration test was failing because it was excepting the 
process to be aborted because of the assertion failure, but that is no longer 
the case in release build. 
   This is causing the master builds to fail.
   ### Modifications
   As in other places, throw an exception when some configuration parameters 
are not valid.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

Reply via email to