maskit commented on issue #672: Support setting private key content in athenz client plugin URL: https://github.com/apache/incubator-pulsar/pull/672#issuecomment-321729113 OK, that makes sense. Since it's just a plugin I don't object introducing its own unique way, however, it sounds like not athenz specific issue. The same issue will appear if somebody tried to use TLS auth, and they would need to re-implement the logic to read secrets from somewhere. Also, all users who read it from environment variables need to implement the logic even though it's not an unique way. How about adding support for URL schemes (e.g. file:, data:, env:, exec:) to privateKeyPath config param? If we provided the reader and plugins used it, the plugins would get the same benefit when we support new scheme (new data source), plus it can be applicable for any configuration parameters. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
With regards, Apache Git Services
