2018-06-05 22:29:26 UTC - Sijie Guo: @Rajan Dhabalia @Jai Asher any of you know where can I find the tag for 4.3.1.91-yahoo ? ---- 2018-06-05 22:35:15 UTC - Rajan Dhabalia: unfortunately yahoo-bk repo doesn't create a tag for a release.. and it's little bit tricky to find appropriate commit for a given version.. But you can find artifact at: <https://github.com/yahoo/bookkeeper/tree/mvn-repo/org/apache/bookkeeper/bookkeeper/4.3.1.91-yahoo>
and commit for which, we have tag: 4.3.1.91-yahoo: <https://github.com/yahoo/bookkeeper/commit/cd463ca1aeebda876fed3724a5c75c54fd4e6948> ---- 2018-06-05 22:36:18 UTC - Sijie Guo: cool thank you ---- 2018-06-05 22:39:26 UTC - Sijie Guo: but this is based on master? ---- 2018-06-05 22:39:55 UTC - Sijie Guo: I thought it is based on yahoo-branch? ---- 2018-06-05 22:41:05 UTC - Matteo Merli: I’d assume it was <https://github.com/yahoo/bookkeeper/commits/yahoo-4.3> ---- 2018-06-05 22:41:47 UTC - Sijie Guo: I am trying to find if `auditorLedgerVerificationPercentage` change is included in 4.3.1.91-yahoo ---- 2018-06-05 22:42:58 UTC - Sijie Guo: 4.3.1.91-yahoo was 4 months ago, so I assume does include this auditorLedgerVerificationPercentage change ---- 2018-06-05 22:43:18 UTC - Sijie Guo: @Rajan Dhabalia wondering if you guys set auditorLedgerVerificationPercentage on your production environments or not? ---- 2018-06-05 22:43:41 UTC - Matteo Merli: it’s indeed included: <https://github.com/yahoo/bookkeeper/blob/yahoo-4.3/bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java#L101> ---- 2018-06-05 22:44:44 UTC - Sijie Guo: yeah. that’s HEAD. I would like to confirm that. If that’s the case, setting a default value 100% is kind of bad. ---- 2018-06-05 22:57:13 UTC - Rajan Dhabalia: @Sijie Guo yes, my bad.. it's based on yahoo-4.3 as Matteo corrected.. ----
