On Thu, Aug 23, 2018 at 11:25 PM Matteo Merli <matteo.me...@gmail.com>
wrote:
> Hi Penghui,
>
> the proposal looks good to me. I like the approach of using interceptors
> since they might be useful in multiple scenarios, for applications to add
> custom logging or processing.
>
> For tracing, in particular, I think we should also aim to have "out of the
> box" ready made solution as well, especially targeting standard APIs like
> OpenTracing. We shouldn't be dictating any particular implementation, but
> we should try to avoid the burden of integrating with tracing APIs to
> application developers.
> Ideally, as a user, I should be able to do something like :
>
> client.newConsumer()
> .topic("xyz")
> .subscriptionName("yyz")
> .withTracing(OpenTracing.of(tracingLoggerConfig))
>
Why can't we use the proposed #intercept(...)? I am not sure we need to
distinguish "tracing" from other interceptors.
client.newConsumer()
.topic("xyz")
.subscriptionName("yyz")
.intercept(OpenTracingInterceptor.of(tracingLoggerConfig))
> .subscribe();
>
> (Or maybe even configure that at the PulsarClient level)
>
>
> On Tue, Aug 21, 2018 at 11:13 AM Sijie Guo <guosi...@gmail.com> wrote:
>
> > Updated. Thanks, Penghui!
> >
> > - Sijie
> >
> > On Tue, Aug 21, 2018 at 3:56 AM 李鹏辉 <codelipeng...@gmail.com> wrote:
> >
> > > Please add zhaijia to Authors.
> > >
> > > Sijie Guo <guosi...@gmail.com> 于2018年8月21日周二 下午6:48写道：
> > >
> > > > Thank you penghui! This is a great feature to add to Pulsar.
> > > >
> > > > I've copied your PIP to pulsar wiki as well :
> > > >
> > > >
> > >
> >
> https://github.com/apache/incubator-pulsar/wiki/PIP-23:-Message-Tracing-By-Interceptors
> > > >
> > > > - Sijie
> > > >
> > > > On Tue, Aug 21, 2018 at 3:14 AM 李鹏辉 <codelipeng...@gmail.com> wrote:
> > > >
> > > > > Dear all
> > > > >
> > > > > This is a PIP to add feature of message trace implement by
> > > interceptors.
> > > > >
> > > > >
> > > > >
> > > >
> > >
> >
> https://docs.google.com/document/d/1aigUKZ-AhQvugOfzUzypyMMeXfum5XlNkwuYK4KvxJs/edit?usp=sharing
> > > > >
> > > > > —
> > > > > Regards,
> > > > > Penghui Li
> > > > >
> > > >
> > >
> >
> --
> Matteo Merli
> <mme...@apache.org>
>
