I'm for breaking backwards compatilbility :

    JavaPackage getPackage()

And staying with Java 1.4 for now.

Only a tiny subset of users will notice the change in signature. And they'll be able to quickly fix their code instead of throwing their toys out of the pram/cot :-)

Regards,

- Paul

On Feb 16, 2009, at 9:34 AM, Robert Scholte wrote:

Ì don't really like the idea of implementing the CharSequence. getPackage() returns a String and I guess most of the referring code will use a String variable.
And it's not making the code really clearer.

There are actually two issues:
- The parser fails if a package contains annotations
- The Model doesn't support annotations on the model.

If we really, really, Really want to stay backwards compatible we should at least solve the first issue. The second issue will (almost) always break backwards compatibility. Pushing it to a 2.0-release sounds more acceptable then resolving it with a 1.8+ release.

And maybe there are more things to pick up with a 2.0-release. For example upgrading to java5 to use generic-Lists instead of arrays in the qdox-code?

regards,

Robert

> Date: Sat, 14 Feb 2009 10:00:20 -0600
> From: [email protected]
> To: [email protected]
> Subject: [qdox-dev] [jira] Commented: (QDOX-98) Parser fails on package with annotations
>
>
> [ http://jira.codehaus.org/browse/QDOX-98?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=165603#action_165603 ]
>
> Paul Hammant commented on QDOX-98:
> ----------------------------------
>
> > if the answer is to change 'String javaSource.getPackage()' to 'JavaPackage javaSource.getPackage()', then that is what we have to do.
>
> And we could make JavaPackage implement CharSequence too, as some (poor?) concession to backwards compatibility.
>
> > Parser fails on package with annotations
> > ----------------------------------------
> >
> > Key: QDOX-98
> > URL: http://jira.codehaus.org/browse/QDOX-98
> > Project: QDox
> > Issue Type: Bug
> > Components: Parser
> > Reporter: Guillaume Nodet
> > Priority: Minor
> >
> > The following file generated by jaxws can not be parsed.
> > @javax.xml.bind.annotation.XmlSchema(namespace = "http://docs.oasis-open.org/wsn/br-2 ")
> > package org.oasis_open.docs.wsn.br_2;
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
> -
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe from this list, please visit:
>
> http://xircles.codehaus.org/manage_email
>
>

Express yourself instantly with MSN Messenger! MSN Messenger

Reply via email to