[
https://issues.apache.org/jira/browse/QPID-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12662311#action_12662311
]
Rob Godfrey commented on QPID-1522:
-----------------------------------
Comments on checking r732307:
CommandImpl.java:
CommandImpl seems to have the Apache license in twice
coding conventions not consistently followed
Commandinfo.java:
modified echo statements do not correct typos:
"You might be quering wrong"...
"Objects might not in the broker currently"
> Refactor Command classes so that more common code is shared.
> -------------------------------------------------------------
>
> Key: QPID-1522
> URL: https://issues.apache.org/jira/browse/QPID-1522
> Project: Qpid
> Issue Type: Improvement
> Components: Java Management : CLI Tool
> Affects Versions: M4
> Reporter: Aidan Skinner
> Assignee: Aidan Skinner
> Attachments:
> 0001-QPID-1522-Raname-Command-class-to-CommandImpl-and-m.patch,
> 0002-QPID-1522-Move-common-code-up-to-CommandImpl.-Renam.patch,
> 0003-QPID-1522-Fix-spelling-error-in-classname.patch,
> 0004-QPID-1522-Move-command-line-constants-to-individual.patch
>
>
> The Command subclasses have some duplicate code which could be shared.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
