[
https://issues.apache.org/jira/browse/QPID-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Ritchie updated QPID-1373:
---------------------------------
Assignee: Aidan Skinner (was: Martin Ritchie)
Status: Open (was: Ready To Review)
Aidan, there isn't much to go on in this JIRA but, if acknowledgeThis() is
supposed to only acknowledge the given message then I think you need a more
robust test.
The test may pass but acknowledgeThis() is actually still doing a multiple ack.
I'll attach a test that I used to validate this for myself.
Always good for tests to have asserts in them :)
Whilst not related to your changes I am surprised that 0-8 and 0-10 do
radically different things in their acknowledgeMessage(tag,multi) methods.
For instance I would expect performing a multi ack to sweek the
_unackedMessageTags to remove values lower than the specified tag.
So I would expect this test to fail:
send(4)
receive 1
receive 2
receive 3
receive 4
// perform a multiple ack of message 2 directly with AMQSession
AMQsession.acknowledgeMessage(2, true);
//Ack the rest of the session.
msg4.ack or session.ack
The error will occur as msg 1 should have been acked twice as the session.ack
just goes through the list of _unackedMessageTags and acks them all.
> AMQSession_0_8.acknowledgeMessage leaves the message on the unack'd message
> map
> -------------------------------------------------------------------------------
>
> Key: QPID-1373
> URL: https://issues.apache.org/jira/browse/QPID-1373
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: M4
> Reporter: Aidan Skinner
> Assignee: Aidan Skinner
> Fix For: M5
>
> Attachments: QPID-1373.patch
>
>
> This leads to hilarity in the unit tests
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:[email protected]
