[
https://issues.apache.org/jira/browse/QPID-1764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694065#action_12694065
]
Martin Ritchie commented on QPID-1764:
--------------------------------------
This change will encorporate the following FtD review notes:
1 0.5 M Removal of old get* Methods from TransactionLog
2 0.5 M Create Abstract BaseTransactionLog class to hold commonalities
with existing TLogs
3 0.5 M Refactor Ref Counting out into BaseTransactionLog
31 0.5 M BDBMS : Enqueue has no rollback operation. [But it never had]
32 0.5 BDBMS : StoreContext needs enqueue/dequeue added.
29 0.5 BDBMS : _dequeueTxMap should move to StoreContext to remove
synchronized
28 BDBMS : linked list per message is not memory conserving
4 0.6 StoreContext update, initially to include the dequeue
messageIds as per BDBStore [also enqueues to fix rollback]
> Create Abstract base class to perform new reference counting for
> TransactionLog
> -------------------------------------------------------------------------------
>
> Key: QPID-1764
> URL: https://issues.apache.org/jira/browse/QPID-1764
> Project: Qpid
> Issue Type: Bug
> Components: Performance
> Reporter: Martin Ritchie
> Assignee: Martin Ritchie
> Priority: Blocker
> Fix For: 0.5
>
>
> Summary:
> Summary the introduction of the new TransactionLog interface over the old
> MessageStore has resulted in each of the old Stores performing their own
> reference counting. As a result they all suffer from:
> a) Being different implementations
> b) Not being fully tested by existing test frameworks.
> By creating a single reference counting TransactionLog base class that
> delegates the simple storage and retreival tasks to the underlying Stores the
> stores can be simpler and the testing more complete.
> Current testing has already shown that performance has knocked 5% by the
> MemoryMessageStore's implementation of reference counting when it should not
> need to be doing any reference counting.
> This was brought up during the FtD Code review
> http://cwiki.apache.org/confluence/display/qpid/FtD+Code+Review+Notes
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:[email protected]
