... and we had *loads* of complaints about this previously ;-( Marnie
On Tue, Sep 22, 2009 at 11:42 AM, Martin Ritchie <[email protected]>wrote: > Rajith, > > One of the reasons we do not currently have a log4j.xml file in the > client package is that all our users will pick this up. > As you say on QPID-2113 Log4j will scan the classpath looking for > log4j.xml then log4j.properties. If it finds one then it will use it. > I'm also not convinced we should have the log4j.properties in common > as log4j can default to that. IIRC the common default used to be used > by our tests. Our systests now use their own configuration and so the > common one can probably be removed. > > Users should be given assistence on configuring their log4j but we > should not bundle a log4j.* in our jars as that will make their > debugging very difficult. Log4j debug will show it is using a > log4j.xml file but not which jar it was loaded from. If your users > bundle all their application files in to a jar, including their log4j > configuration then you are relying on the classpath to select the > log4j.* file to use. > > If users are having difficulty with excessive DEBUG messages then I > would suggest that we simply need to advertise the client.log4j file > that we ship better. > Asking users to set -Dlog4j.configuration=client.log4j to get our > default logging is much easier to explain IMHO than explaining why a > users log4j.xml configuration file is not working. > > Regards > > Martin > > > 2009/9/22 <[email protected]>: > > Author: rajith > > Date: Tue Sep 22 00:13:05 2009 > > New Revision: 817457 > > > > URL: http://svn.apache.org/viewvc?rev=817457&view=rev > > Log: > > This is a fix for QPID-2113 > > I didn't meddle with the existing log4j.properties file present in the > common module as it maybe used in the broker. > > However a cursory glance at the etc directory revealed that the the > broker too has a log4j.xml file. > > > > So perhaps the log4j.properties files in the common module is not really > needed. > > (The settings given i the log4j.xml under the client module could be > overriden by explicitly specifying a log4.xml file using -Dlog.configuration > property) > > > > Added: > > qpid/trunk/qpid/java/client/src/main/java/log4j.xml > > > > Added: qpid/trunk/qpid/java/client/src/main/java/log4j.xml > > URL: > http://svn.apache.org/viewvc/qpid/trunk/qpid/java/client/src/main/java/log4j.xml?rev=817457&view=auto > > > ============================================================================== > > --- qpid/trunk/qpid/java/client/src/main/java/log4j.xml (added) > > +++ qpid/trunk/qpid/java/client/src/main/java/log4j.xml Tue Sep 22 > 00:13:05 2009 > > @@ -0,0 +1,36 @@ > > +<!-- > > + > > + - > > + - Licensed to the Apache Software Foundation (ASF) under one > > + - or more contributor license agreements. See the NOTICE file > > + - distributed with this work for additional information > > + - regarding copyright ownership. The ASF licenses this file > > + - to you under the Apache License, Version 2.0 (the > > + - "License"); you may not use this file except in compliance > > + - with the License. You may obtain a copy of the License at > > + - > > + - http://www.apache.org/licenses/LICENSE-2.0 > > + - > > + - Unless required by applicable law or agreed to in writing, > > + - software distributed under the License is distributed on an > > + - "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY > > + - KIND, either express or implied. See the License for the > > + - specific language governing permissions and limitations > > + - under the License. > > + - > > +--> > > + > > +<log4j:configuration xmlns:log4j="http://jakarta.apache.org/log4j/";> > > + <appender name="console" class="org.apache.log4j.ConsoleAppender"> > > + <param name="Target" value="System.out"/> > > + <layout class="org.apache.log4j.PatternLayout"> > > + <param name="ConversionPattern" value="%-5p %c{1} - %m%n"/> > > + </layout> > > + </appender> > > + > > + <logger name="org.apache.qpid"> > > + <level value="warn"/> > > + <appender-ref ref="console" /> > > + </logger> > > + > > +</log4j:configuration> > > > > > > > > --------------------------------------------------------------------- > > Apache Qpid - AMQP Messaging Implementation > > Project: http://qpid.apache.org > > Use/Interact: mailto:[email protected] > > > > > > > > -- > Martin Ritchie > > --------------------------------------------------------------------- > Apache Qpid - AMQP Messaging Implementation > Project: http://qpid.apache.org > Use/Interact: mailto:[email protected] > >
