On 11/30/2009 10:52 AM, Andrew Stitcher wrote:
On Fri, 2009-11-27 at 11:33 -0500, Alan Conway wrote:
...
Point taken and apologies again. Lets have the discussion now and if we come up
with a better solution I'll be happy to implement it. I've opened:
https://issues.apache.org/jira/browse/QPID-2223
One comment I'd make is that the implementation is, how shall I put it,
unscalable.
Using a vector, and sorting it for every insertion of a plugin, starts
to be a problem if you have a large number of plugins. Okay, you'd
probably need many more plugins than we currently have but isn't that
what we have the set<> or perhaps map<> data structures for?
If the sort was run just once after all the plugins have been added it'd
be fine, but otherwise I'd suggest using a set<> with a custom "operator
<".
I'd be surprised if anyone ever loaded 1000s or even 100s of plugins, but it
would be easy to fix if you think that's a real concern.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:[email protected]
