[
https://issues.apache.org/jira/browse/QPID-2240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787228#action_12787228
]
Aidan Skinner commented on QPID-2240:
-------------------------------------
I think this patch is OK in principle, a couple of minor nits:
chunks of commented out code, these should just be removed instead.
Qpid style preference is to always use braces for one line blocks:
if (foo) {
bar()
}
instead of
if (foo)
bar()
Other than that I don't see a problem with it, it's definitely better than
leaving the bugs unfixed. It'd be good to get another set of eyes on it though
since I'm not *hugely* familiar with this part of the codebase.
> [.Net 0-10] When authentication fails on connect(), the api should raise an
> exception
> --------------------------------------------------------------------------------------
>
> Key: QPID-2240
> URL: https://issues.apache.org/jira/browse/QPID-2240
> Project: Qpid
> Issue Type: Bug
> Components: Dot Net Client
> Affects Versions: 0.5
> Reporter: Julien Lavigne du Cadet
> Attachments: qpid-dotnet.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:[email protected]
