Hi Andrew, I'll respond in more depth tomorrow, but for now I'd just like to note that I'm not proposing to add a new transport - I just want to stick a shim between the existing transport and the aio, on Windows only.
-Steve -----Original Message----- From: Andrew Stitcher [mailto:[email protected]] Sent: Monday, December 14, 2009 7:31 PM To: Qpid Dev List; Steve Huston Subject: r890481 Changes to TCPConnector implementation Quoting from a comment I just added to QPID-2270: " Whilst I think that the TCPConnector should indeed be in it's own file, and I support that change. I'm very much against using inheritance as an extension mechanism to reuse existing implementation code, and it looks exactly like this is the strategy here otherwise you would be able to follow the example of the other Connector implementations and have the class definition inline with the implentation, both in the TCPConnector.cpp file. " As an added note I don't think adding in a new transport to qpid just before a release is a good plan, so there is every likelihood I will back it out if you do it in the next week or so before I prepare the release candidate. I'd suggest creating a branch to do this work. Andrew --------------------------------------------------------------------- Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:[email protected] --------------------------------------------------------------------- Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:[email protected]
