[ 
https://issues.apache.org/jira/browse/QPID-2335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12800335#action_12800335
 ] 

john dunning commented on QPID-2335:
------------------------------------

Yes, I thought about (and tried) making the cosntructor for XmlBinding mimic 
the others, but take an extra arg for query.  That works, in the sense that it 
fixes the original bug.  That wasn't my first choice, because it seemed wrong 
to (somewhat gratuitously) make that class have a constructor with a different 
signature that his siblings, but maybe we don't care.  If the community feels 
like it's more tasteful to do it that way than to do the parsing in the 
constructor, that's fine with me.

You're also correct that the issue about when the registration of the object 
happens w/r/t the constructor deserves a separate bug.  I'll clone this one or 
open a new one or something along in here for that issue.  But see below...

Re the bigger  concern, it wasn't simply about access to the mgmtobject, but 
about access to the binding itself.  If you've stashed that object in some 
global location where other threads can get at it, prior to finishing execution 
of all the parts of the constructor, you've got a race condition.  That's the 
situation I thought I had with my modified constructor.  I was sure I'd tripped 
over that in the process of running some test code.

Since then, I changed some stuff around, and svn updated, and now I can't 
reproduce that error any more.  I need to do some more careful testing and code 
inspection, and try to determine whether the bug is really there (meaning I was 
unlucky before, and got lucky now) or whether I was confusing myself with 
something that just looked like the race condition, but wasn't really.

> Arguments for a binding to an XML exchange are not visible through management
> -----------------------------------------------------------------------------
>
>                 Key: QPID-2335
>                 URL: https://issues.apache.org/jira/browse/QPID-2335
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Broker
>    Affects Versions: 0.6
>            Reporter: Ted Ross
>            Assignee: Ted Ross
>            Priority: Minor
>
> If you create a binding to the XML exchange (using 
> python/examples/xml-exchange/declare_queues.py for example), then look at the 
> binding using qpid-tool, the arguments field is {} (an empty map).
> Arguments for headers exchanges can be viewed correctly, this only affects 
> the xml exchange.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:[email protected]

Reply via email to