[
https://issues.apache.org/jira/browse/QPID-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12803522#action_12803522
]
Andrew Stitcher commented on QPID-1403:
---------------------------------------
Comments on the patch of 8 Jan 2010:
Naming:
I think you should rename SslIoShim/ClientSslIoShim/ServerSslIoShim to reflect
that these are actually all AsynchIO implementations:
So maybe use names: SslAsynchIO/ClientSslAsynchIO etc.
I like the implementation in SslProtocolFactory except separating the Client
and Server IO is somewhat clunky.
I really don't like the way that SslConnector works though, there's a lot of
code just to put in place a few necessary interceptions. Also the Connectors
were never intended to be inherited from just to implement an interface.
I think this could be handled better by modifying TCPConnector to take an
abstract factory that knows how to create AsynchIO/AsyncConnector objects that
are relevant for the protocol. Then I'd say it'd be better to recast some of
the logic in SslConnector as an implementation of AsynchConnector. Does that
make sense? Of course this does mean a change in the protocol plugin API, but
an improvement I think.
Long term I'd like to eliminate the distinction between the ..Connector and
..ProtocolFactory plugins and be able to use just one for both client and
server - this would likely be descended from the server code which already does
both server and client ends.
AsyncIOBufferBase::squish() this could be better named? And as you've added it,
perhaps you could make the logic in AsynchIO::unread() use it?
In the windows code: It is the general code convention that all system calls
are explicitly called out by being explicitly in the global namespace, viz
::InitializeSecurityContext() to give the first example I came across.
Personally I'd put both the Client "shim" and the Server "shim" code in the
same implementation file (but that's mostly a my own preference)
> Add SSL support for C++ Windows broker/client
> ---------------------------------------------
>
> Key: QPID-1403
> URL: https://issues.apache.org/jira/browse/QPID-1403
> Project: Qpid
> Issue Type: New Feature
> Components: C++ Broker, C++ Client
> Affects Versions: M4
> Environment: Windows XP+
> Reporter: Steve Huston
> Assignee: Steve Huston
> Attachments: ssl-windows.patch
>
>
> The recently added SSL support in the C++ side should be available to Windows
> as well. Not yet sure how much architectural work this may be.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:[email protected]
