[ 
https://issues.apache.org/jira/browse/QPID-2363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12805253#action_12805253
 ] 

Rob Godfrey commented on QPID-2363:
-----------------------------------

Had a quick look at the patch...

My other comments would be

Why not allow the 0-8 codepath to decode amqp maps (or even to encode them - 
though I would suggest not as the default)...  the code is there and for 
interop reasons it might be useful if you could send an 0-10 map message via 
the java broker to a client working in 0-8 mode...

I don't really like the encode / decode on the message delegate... seems like 
it could just be on the AMQPEncodedMapMessage as the implementation of 
populateMapFromData / writeMapToData (this sort of links with the above)

> JMS Map Message Should Support AMQP 0-10 Encoded Map As Message Body
> --------------------------------------------------------------------
>
>                 Key: QPID-2363
>                 URL: https://issues.apache.org/jira/browse/QPID-2363
>             Project: Qpid
>          Issue Type: New Feature
>          Components: Interop Testing, Java Client
>            Reporter: Rajith Attapattu
>            Assignee: Rajith Attapattu
>             Fix For: 0.7
>
>         Attachments: QPID-2363.patch
>
>
> As part of the new API initiative in Qpid, the C++ client and python client 
> have added support for a map message, where the content is a map of key,value 
> pairs encoded using the AMQP 0-10 encoding for Maps.
> Currently the JMS Map message body is encoded as an opaque binary blob. 
> We need to add support for the JMS Map message implementation to set an AMQP 
> 0-10 encoded Map for the message body. 
> This allows inteoperability btw JMS Map messages and c++, python map messages.
> The content-type for the proposed map message is "amqp/map".
> This feature is only added to the 0-10 code path as the versions below AMQP 
> 0-10 does not have any native support for encoding maps.
> The new map message format will be the default for any map message created by 
> a 0-10 Session.
> If it needs to send any messages using the old map message format it will 
> need to use the following jvm arg "-Dqpid.use_legacy_map_message=true"
> Once the addressing support is finalized we could also add a per destination 
> flag to indicate if legacy messages needs to be used or not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:[email protected]

Reply via email to