Would be good if you could update the svn commit log message and comment on 2404.
Cheers Martin On 17 February 2010 14:07, Rajith Attapattu <rajit...@gmail.com> wrote: > The commit is related to QPID-1575 not QPID-2404. > Thx to Gordon for pointing it out. > > On Tue, Feb 16, 2010 at 6:51 PM, <raj...@apache.org> wrote: >> Author: rajith >> Date: Tue Feb 16 23:51:40 2010 >> New Revision: 910777 >> >> URL: http://svn.apache.org/viewvc?rev=910777&view=rev >> Log: >> This is related to QPID-2404 >> The C++ broker removes stales messages using the following strategies >> a) If a consumer requests a messages, it checks the head and discards it if >> it's expired >> b) Runs the queue cleaner thread every x (defaults to 5 mins) secs and >> discards stale messages. >> >> I enabled the TimeToLiveTest (by commenting it out) and reduced the >> --queue-purge-interval to 1 sec. >> This may interfere with other tests. If that happens I will try to increase >> above interval and the test timeout and see if we could get by. >> >> >> Modified: >> qpid/trunk/qpid/java/test-profiles/CPPExcludes >> qpid/trunk/qpid/java/test-profiles/cpp.testprofile >> >> Modified: qpid/trunk/qpid/java/test-profiles/CPPExcludes >> URL: >> http://svn.apache.org/viewvc/qpid/trunk/qpid/java/test-profiles/CPPExcludes?rev=910777&r1=910776&r2=910777&view=diff >> ============================================================================== >> --- qpid/trunk/qpid/java/test-profiles/CPPExcludes (original) >> +++ qpid/trunk/qpid/java/test-profiles/CPPExcludes Tue Feb 16 23:51:40 2010 >> @@ -59,7 +59,7 @@ >> // c++ broker doesn't support priorities, TTL or message bouncing >> org.apache.qpid.server.exchange.ReturnUnroutableMandatoryMessageTest#* >> org.apache.qpid.server.queue.PriorityTest#* >> -org.apache.qpid.server.queue.TimeToLiveTest#* >> +#org.apache.qpid.server.queue.TimeToLiveTest#* >> >> // QPID-1727 , QPID-1726 :c++ broker does not support flow to disk on >> transient queues. Also it requries a persistent store impl. for Apache >> org.apache.qpid.test.client.QueueBrowsingFlowToDiskTest#* >> >> Modified: qpid/trunk/qpid/java/test-profiles/cpp.testprofile >> URL: >> http://svn.apache.org/viewvc/qpid/trunk/qpid/java/test-profiles/cpp.testprofile?rev=910777&r1=910776&r2=910777&view=diff >> ============================================================================== >> --- qpid/trunk/qpid/java/test-profiles/cpp.testprofile (original) >> +++ qpid/trunk/qpid/java/test-profiles/cpp.testprofile Tue Feb 16 23:51:40 >> 2010 >> @@ -12,7 +12,7 @@ >> broker.stopped=Exception constructed >> >> broker.modules= >> -broker.args= >> +broker.args=--queue-purge-interval 1 >> >> broker=${broker.executable} -p @PORT --data-dir ${build.data}/@PORT -t >> --auth no --no-module-dir ${broker.modules} ${broker.args} >> >> >> >> >> --------------------------------------------------------------------- >> Apache Qpid - AMQP Messaging Implementation >> Project: http://qpid.apache.org >> Use/Interact: mailto:commits-subscr...@qpid.apache.org >> >> > > > > -- > Regards, > > Rajith Attapattu > Red Hat > http://rajith.2rlabs.com/ > > --------------------------------------------------------------------- > Apache Qpid - AMQP Messaging Implementation > Project: http://qpid.apache.org > Use/Interact: mailto:dev-subscr...@qpid.apache.org > > -- Martin Ritchie --------------------------------------------------------------------- Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org