[
https://issues.apache.org/jira/browse/QPID-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12879773#action_12879773
]
Rajith Attapattu commented on QPID-2657:
----------------------------------------
First of all, thanks for doing this.
I have been meaning to do this for a while now.
I have the following questions about the patch.
In @@ -139,36 +139,24 @@ public class BasicMessageConsumer_0_10 ... you have
added the following code.
+ if (isMessageListenerSet() && capacity == 0)
+ {
+
_0_10session.getQpidSession().messageFlow(getConsumerTagString(),
+
MessageCreditUnit.MESSAGE, 1,
+
Option.UNRELIABLE);
+ }
+ _logger.debug("messageOk, trying to notify");
+ super.notifyMessage(jmsMessage);
1. What is the reason for adding this?
2. How is this related to exception handling? (or is this part of some other
JIRA that got accidentally added to this patch ?)
3. Have you run the tests against the 0-10 cpp broker profiles?
In general If any code is modified in the 0-10 client side, I'd like to kindly
request that the 0-10 cpp broker test profiles are run before the patch is
committed.
> Verify/correct error handling on client 0-10 codepath
> -----------------------------------------------------
>
> Key: QPID-2657
> URL: https://issues.apache.org/jira/browse/QPID-2657
> Project: Qpid
> Issue Type: Bug
> Affects Versions: 0.7
> Reporter: Andrew Kennedy
> Fix For: 0.7
>
> Attachments:
> 0003-QPID-2657-Make-Exceptions-propagate-to-client-for-0.patch
>
>
> Verify and correct existing error handling on 0-10 CLIENT codepath:
> - whats the structure and how does it compare with whats there on the 0-9
> codepath ?
> - do errors thrown to the client from the broker have the correct result on
> an open connection/session/producer/consumer ?
> - is logging correctly implemented ?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:[email protected]
