[
https://issues.apache.org/jira/browse/QPIDJMS-544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17387216#comment-17387216
]
Robbie Gemmell commented on QPIDJMS-544:
----------------------------------------
Yep, the field value used should be logged rather than the constant it
originally defaults to. Its not really expected that it would change as its not
a documented option, but if it does the logging is clearly wrong. I fixed that
and tweaked the message text for clarity.
> JmsDefaultPrefetchPolicy#getMaxPrefetchLimit logs incorrect MAX_PREFETCH_SIZE
> -----------------------------------------------------------------------------
>
> Key: QPIDJMS-544
> URL: https://issues.apache.org/jira/browse/QPIDJMS-544
> Project: Qpid JMS
> Issue Type: Bug
> Components: qpid-jms-client
> Affects Versions: 1.0.0, 1.1.0
> Reporter: Alexander Scott
> Assignee: Robbie Gemmell
> Priority: Trivial
>
> When using the `JmsDefaultPrefetchPolicy` and setting a prefetch limit,
> prefetch values greater than the `maxPrefetchSize` are logged as being reset
> to the `MAX_PREFETCH_SIZE`. I believe `MAX_PREFETCH_SIZE` should be changed
> to `maxPrefetchSize`.
>
>
> {noformat}
> private int getMaxPrefetchLimit(int value) {
> int result = Math.min(value, maxPrefetchSize);
> if (result < value) {
> LOG.warn("maximum prefetch limit has been reset from " + value + " to
> " + MAX_PREFETCH_SIZE);
> }
> return result;
> }{noformat}
>
>
> {noformat}
> private int getMaxPrefetchLimit(int value) {
> int result = Math.min(value, maxPrefetchSize);
> if (result < value) {
> LOG.warn("maximum prefetch limit has been reset from " + value + " to
> " + maxPrefetchSize);
> }
> return result;
> }{noformat}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
