[
https://issues.apache.org/jira/browse/DISPATCH-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17388562#comment-17388562
]
ASF GitHub Bot commented on DISPATCH-2214:
------------------------------------------
jiridanek commented on a change in pull request #1327:
URL: https://github.com/apache/qpid-dispatch/pull/1327#discussion_r678070407
##########
File path: tests/system_tests_tcp_adaptor.py
##########
@@ -528,6 +530,15 @@ def router(name, mode, connection, extra=None):
unseen = [srv for srv in cls.router_order if "ES_" + srv
not in seen]
cls.logger.log("TCP_TEST Router %s sees only %d of %d
addresses. Waiting for %s" %
(rtr, len(server_lines),
len(cls.router_order), unseen))
+ if poll_loops == 1:
+ # last poll loop
+ for line in lines:
+ cls.logger.log("TCP_TEST Router %s : %s" % (rtr, line))
+ poll_loops -= 1
+ if poll_loops == 0:
+ assert False, "TCP_TEST TCP_Adaptor test setup failed. Echo
tests never executed."
Review comment:
```suggestion
self.fail("TCP_TEST TCP_Adaptor test setup failed. Echo
tests never executed.")
```
https://docs.python.org/3/library/unittest.html#unittest.TestCase.fail
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> TCP Adaptor test prints too much logging when echo server fail to connect
> -------------------------------------------------------------------------
>
> Key: DISPATCH-2214
> URL: https://issues.apache.org/jira/browse/DISPATCH-2214
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Tests
> Affects Versions: 1.16.1
> Reporter: Charles E. Rolke
> Priority: Major
>
> For whatever reason some echo server may fail to connect. If so then the test
> logs thousands of lines saying that not all servers connected. The result is
> that the logs of just this test consume the disk quota of all the other tests.
> The goal of this issue is to back off the logging and to fail earlier if the
> servers never connect.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
