[
https://issues.apache.org/jira/browse/DISPATCH-2223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17393822#comment-17393822
]
ASF GitHub Bot commented on DISPATCH-2223:
------------------------------------------
codecov-commenter commented on pull request #1333:
URL: https://github.com/apache/qpid-dispatch/pull/1333#issuecomment-893043451
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1333?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#1333](https://codecov.io/gh/apache/qpid-dispatch/pull/1333?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(af64b43) into
[main](https://codecov.io/gh/apache/qpid-dispatch/commit/25360c6cf6655e85cfb521e0c475b8a6a12bc592?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(25360c6) will **increase** coverage by `0.00%`.
> The diff coverage is `90.00%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/1333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## main #1333 +/- ##
=======================================
Coverage 84.65% 84.66%
=======================================
Files 113 114 +1
Lines 28383 28394 +11
=======================================
+ Hits 24029 24041 +12
+ Misses 4354 4353 -1
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[src/pythoncapi\_compat.h](https://codecov.io/gh/apache/qpid-dispatch/pull/1333/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3B5dGhvbmNhcGlfY29tcGF0Lmg=)
| `86.66% <86.66%> (ø)` | |
|
[src/python\_embedded.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1333/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3B5dGhvbl9lbWJlZGRlZC5j)
| `68.43% <100.00%> (-0.26%)` | :arrow_down: |
|
[src/router\_pynode.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1333/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9weW5vZGUuYw==)
| `87.85% <100.00%> (-0.12%)` | :arrow_down: |
|
[src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1333/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
| `94.18% <0.00%> (-0.44%)` | :arrow_down: |
|
[src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1333/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21lc3NhZ2UuYw==)
| `87.49% <0.00%> (-0.07%)` | :arrow_down: |
|
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1333/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
| `93.55% <0.00%> (+0.11%)` | :arrow_up: |
|
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1333/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
| `90.46% <0.00%> (+0.29%)` | :arrow_up: |
|
[src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1333/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j)
| `93.04% <0.00%> (+0.39%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1333?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1333?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[25360c6...af64b43](https://codecov.io/gh/apache/qpid-dispatch/pull/1333?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Incorporate pythoncapi_compat.h to keep up with CPython development
> -------------------------------------------------------------------
>
> Key: DISPATCH-2223
> URL: https://issues.apache.org/jira/browse/DISPATCH-2223
> Project: Qpid Dispatch
> Issue Type: Improvement
> Reporter: Jiri Daněk
> Assignee: Jiri Daněk
> Priority: Major
> Fix For: 1.18.0
>
> Attachments: image-2021-08-04-17-58-13-223.png
>
>
> The library pythoncapi_compat is a simple (so far) header file that contains
> backports of Python C API utility functions, plus a script with tries to
> rewrite older code constructs to use these utility functions.
> https://vstinner.github.io/pythoncapi_compat.html
> In Dispatch there is very few changes that would be required to adopt all the
> utilities.
> Having this could be useful for the future, since there were recent
> developments and improvements to the C Python API in Python 3.8-3.10, and
> there may be more. This way, it is possible to keep up in a compatible way.
> !image-2021-08-04-17-58-13-223.png!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
