[ 
https://issues.apache.org/jira/browse/DISPATCH-2222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17396794#comment-17396794
 ] 

ASF subversion and git services commented on DISPATCH-2222:
-----------------------------------------------------------

Commit 182138cfe21b1f0b921590bb9344b18588e1c368 in qpid-dispatch's branch 
refs/heads/dependabot/npm_and_yarn/console/react/browserslist-4.16.7 from Ken 
Giusti
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=182138c ]

DISPATCH-2222: avoid per-message logging overhead when not tracing

This closes #1330


> Avoid cpu-intensive message string-ify of every received AMQP message
> ---------------------------------------------------------------------
>
>                 Key: DISPATCH-2222
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-2222
>             Project: Qpid Dispatch
>          Issue Type: Bug
>          Components: Router Node
>    Affects Versions: 1.17.0
>            Reporter: Ken Giusti
>            Assignee: Ken Giusti
>            Priority: Major
>             Fix For: 1.18.0
>
>
> A call to log_link_message() is made for every received AMQP message.  This 
> function logs a string-ified version of the message at level QD_LOG_TRACE.
>  
> log_link_message() parses out each message and summarizes it into a string 
> buffer before logging.  This stringify operation is cpu-intensive.  According 
> to flamegraphs it occupies 5% of the compute budget.
>  
> The string-ify operation should be avoided if the message log level doe not 
> have TRACE enabled.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to