[ 
https://issues.apache.org/jira/browse/PROTON-2407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17400291#comment-17400291
 ] 

ASF GitHub Bot commented on PROTON-2407:
----------------------------------------

jiridanek commented on a change in pull request #332:
URL: https://github.com/apache/qpid-proton/pull/332#discussion_r690202302



##########
File path: python/proton/_data.py
##########
@@ -1158,7 +1154,7 @@ def get_map(self) -> int:
         """
         return pn_data_get_map(self._data)
 
-    def get_array(self):
+    def get_array(self) -> Tuple[int, bool, Optional[int]]:

Review comment:
       ```suggestion
       def get_array(self) -> Optional[Tuple[int, bool, int]]:
   ```
   
   hmm, possibly the correct type is actually this; in any case, what the doc 
used to say was wrong




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


> [proton-python] add type annotations
> ------------------------------------
>
>                 Key: PROTON-2407
>                 URL: https://issues.apache.org/jira/browse/PROTON-2407
>             Project: Qpid Proton
>          Issue Type: New Feature
>          Components: python-binding
>    Affects Versions: proton-c-0.35.0
>            Reporter: Jiri Daněk
>            Assignee: Jiri Daněk
>            Priority: Major
>             Fix For: proton-c-0.36.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to