[
https://issues.apache.org/jira/browse/DISPATCH-2235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17403915#comment-17403915
]
ASF GitHub Bot commented on DISPATCH-2235:
------------------------------------------
kgiusti commented on a change in pull request #1346:
URL: https://github.com/apache/qpid-dispatch/pull/1346#discussion_r694994166
##########
File path: src/router_core/forwarder.c
##########
@@ -154,7 +154,9 @@ qdr_delivery_t *qdr_forward_new_delivery_CT(qdr_core_t
*core, qdr_delivery_t *in
out_dlv->delivery_id = next_delivery_id();
out_dlv->link_id = out_link->identity;
out_dlv->conn_id = out_link->conn_id;
- out_dlv->dispo_lock = sys_mutex();
+ char name[64];
+ snprintf(name, sizeof(name), "delivery-%"PRIu32, out_dlv->delivery_id);
Review comment:
It's probably overkill, especially for this lock which is hardly used.
In fact we probably want to avoid storing the mutex name (strdup call) when
we're not explicitly debugging the locks.
Update coming soon...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Add debug code for timing lock acquire latency
> ----------------------------------------------
>
> Key: DISPATCH-2235
> URL: https://issues.apache.org/jira/browse/DISPATCH-2235
> Project: Qpid Dispatch
> Issue Type: New Feature
> Components: Router Node
> Affects Versions: 1.17.0
> Reporter: Ken Giusti
> Assignee: Ken Giusti
> Priority: Major
> Fix For: 1.18.0
>
>
> Add code to record the time delay between requesting a mutex and obtaining
> the mutex.
>
> This is debug code and is only enabled when the router is compiled with the
> following preprocessor symbol defined: QD_TRACE_LOCK_CONTENTION
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
