[
https://issues.apache.org/jira/browse/DISPATCH-2246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17412215#comment-17412215
]
ASF GitHub Bot commented on DISPATCH-2246:
------------------------------------------
jiridanek commented on a change in pull request #1365:
URL: https://github.com/apache/qpid-dispatch/pull/1365#discussion_r704821655
##########
File path: tests/system_tests_tcp_adaptor.py
##########
@@ -347,12 +342,12 @@ def router(name, mode, connection, extra=None):
ofilename=os.path.join(parent_path,
"setUpClass/TcpAdaptor_echo_server_%s.log" % rtr))
cls.logger.log("TCP_TEST Launching echo server '%s'" %
server_prefix)
server = TcpEchoServer(prefix=server_prefix,
- port=cls.tcp_server_listener_ports[rtr],
+ port=0,
logger=server_logger)
assert server.is_running
Review comment:
Previously, this suffered from a race condition; what if the new thread
took its time setting this variable?
Not that I ever saw this specific assert to fail, to be honest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> The 'Address already in use` test issue, in echo server
> -------------------------------------------------------
>
> Key: DISPATCH-2246
> URL: https://issues.apache.org/jira/browse/DISPATCH-2246
> Project: Qpid Dispatch
> Issue Type: Test
> Affects Versions: 1.18.0
> Reporter: Jiri Daněk
> Priority: Major
>
> https://github.com/apache/qpid-dispatch/pull/1363/checks?check_run_id=3505223174#step:27:2222
> {noformat}
> 72: E AssertionError: 'ECHO_SERVER ES_TCPMgmtTest Opening listen socket
> 127.0.0.1:27392 exception: Traceback (most recent call last):\n File
> "/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/tests/TCP_echo_server.py",
> line 132, in run\n self.sock.bind((self.HOST, self.port))\nOSError:
> [Errno 98] Address already in use\n' is not None
> 72:
> 72:
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/tests/system_tests_tcp_adaptor.py:1082:
> AssertionError
> 72: - generated xml file:
> /__w/qpid-dispatch/qpid-dispatch/qpid-dispatch/build/tests/junitxmls/system_tests_tcp_adaptor.xml
> -
> 72: =========================== short test summary info
> ============================
> 72: FAILED ::TcpAdaptorManagementTest::test_01_mgmt - AssertionError:
> 'ECHO_SERVE...
> 72: =================== 1 failed, 8 passed, 2 skipped in 25.20s
> ====================
> 35/37 Test #72: system_tests_tcp_adaptor ..........................***Failed
> 25.87 sec
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
