[
https://issues.apache.org/jira/browse/PROTON-2433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Stitcher updated PROTON-2433:
------------------------------------
Description:
I build Proton and install it in ~/Work/qpid-install
...
{{> ninja install}}
...
I create a simple CMakeFiles.txt:
{noformat}
cmake_minimum_required(VERSION 2.8.12 FATAL_ERROR)
project(amqp-value-parser)
find_package(Proton 0.28 REQUIRED)
add_executable (amqp-value-test main.c)
target_link_libraries (amqp-value-test amqp-value Proton::core)
{noformat}
I use cmake like so:
{{> cmake -G Ninja -D CMAKE_INSTALL_PREFIX=~/Work/qpid-install}}
Compiles fail to correctly find the include files for proton.
I think because this work has removed this section and hasn't replaced it with
anything else that does the same thing.
{noformat}
# Add modular target in a way compatible with cmake 2.8.12
if (NOT TARGET Proton::core)
add_library(Proton::core UNKNOWN IMPORTED)
set_target_properties(Proton::core
PROPERTIES
IMPORTED_LOCATION "@LIBDIR@/@PROTONCORELIB@"
IMPORTED_LOCATION_DEBUG "@LIBDIR@/@PROTONCORELIBDEBUG@"
INTERFACE_INCLUDE_DIRECTORIES "${Proton_Core_INCLUDE_DIRS}")
endif()
{noformat}
As the original work was only an improvement we either need to fix this very
soon or revert the original change.
was:
I build Proton and install it in ~/Work/qpid-install
...
> ninja install
...
I create a simple CMakeFiles.txt:
{noformat}
cmake_minimum_required(VERSION 2.8.12 FATAL_ERROR)
project(amqp-value-parser)
find_package(Proton 0.28 REQUIRED)
dd_executable (amqp-value-test main.c)
target_link_libraries (amqp-value-test amqp-value Proton::core)
{noformat}
This now fails to correctly find the include files for the compile. I think
because this work has removed this section and hasn't replaced it with anything
else that does the same thing.
{noformat}
# Add modular target in a way compatible with cmake 2.8.12
if (NOT TARGET Proton::core)
add_library(Proton::core UNKNOWN IMPORTED)
set_target_properties(Proton::core
PROPERTIES
IMPORTED_LOCATION "@LIBDIR@/@PROTONCORELIB@"
IMPORTED_LOCATION_DEBUG "@LIBDIR@/@PROTONCORELIBDEBUG@"
INTERFACE_INCLUDE_DIRECTORIES "${Proton_Core_INCLUDE_DIRS}")
endif()
{noformat}
As the original work was only an improvement we either need to fix this very
soon or revert the original change.
> The work for PROTON-2254 seems to have broken modern use of CMake
> -----------------------------------------------------------------
>
> Key: PROTON-2433
> URL: https://issues.apache.org/jira/browse/PROTON-2433
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c
> Affects Versions: proton-c-0.36.0
> Reporter: Andrew Stitcher
> Assignee: Jiri Daněk
> Priority: Major
>
> I build Proton and install it in ~/Work/qpid-install
> ...
> {{> ninja install}}
> ...
> I create a simple CMakeFiles.txt:
> {noformat}
> cmake_minimum_required(VERSION 2.8.12 FATAL_ERROR)
> project(amqp-value-parser)
> find_package(Proton 0.28 REQUIRED)
> add_executable (amqp-value-test main.c)
> target_link_libraries (amqp-value-test amqp-value Proton::core)
> {noformat}
> I use cmake like so:
> {{> cmake -G Ninja -D CMAKE_INSTALL_PREFIX=~/Work/qpid-install}}
> Compiles fail to correctly find the include files for proton.
> I think because this work has removed this section and hasn't replaced it
> with anything else that does the same thing.
> {noformat}
> # Add modular target in a way compatible with cmake 2.8.12
> if (NOT TARGET Proton::core)
> add_library(Proton::core UNKNOWN IMPORTED)
> set_target_properties(Proton::core
> PROPERTIES
> IMPORTED_LOCATION "@LIBDIR@/@PROTONCORELIB@"
> IMPORTED_LOCATION_DEBUG "@LIBDIR@/@PROTONCORELIBDEBUG@"
> INTERFACE_INCLUDE_DIRECTORIES "${Proton_Core_INCLUDE_DIRS}")
> endif()
> {noformat}
> As the original work was only an improvement we either need to fix this very
> soon or revert the original change.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
