Hi Danushka, I took a closer look at your patch for QPID-2726 and still couldn't help feeling it wasn't the right way to go. I've discussed it with some others to see what their opinion was and they agreed that it doesn't really fit with the intended functionality of those objects/methods, and implementing an accompanying custom SaslServer object for your new PrincipalDatabase would be a more appropriate solution.
To make that process quicker for you I have checked in a change to PlainSaslServer which moves the password verification into a protected method that you can override in a subclass and perform the necessary steps to authenticate against your custom data. You can also subclass and override the relevant creation/registration methods in PlainSaslServerFactory and PlainInitialiser to create the new SaslServer and return the new factory class, ultimately using the new initialiser within your custom PrincipalDatabase to register your new SaslServer for use. As you are going to be using your new PrincipalDatabase instead of one of the existing PrincipalDatabases, the existing PlainSaslServer thus won't be used. I'll try and take a look at QPID-2720 soon. Robbie > -----Original Message----- > From: Danushka Menikkumbura [mailto:[email protected]] > Sent: 08 July 2010 11:36 > To: [email protected] > Subject: Re: Apply patches for QPID-2720 and QPID-2726 > > Hi Robbie, > > I have done the changes and attached the new pate. > > Thanks, > Danushka > > -- > Danushka Menikkumbura > Apache Axis2 PMC Member > > Apache Qpid - World Domination through Advanced Message Queueing ; > http://qpid.apache.org > > phone : +94 77 364 1754 > personal blog : http://danushka-menikkumbura.blogspot.com/ > <http://danushka-menikkumbura.blogspot.com/>technical blog : > http://danushkastechythoughts.blogspot.com/ > <http://danushkastechythoughts.blogspot.com/>twitter : > http://twitter.com/danushkamenik > <http://twitter.com/danushkamenik>linkedin : > http://lk.linkedin.com/in/danushka --------------------------------------------------------------------- Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:[email protected]
