[
https://issues.apache.org/jira/browse/DISPATCH-1487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17428467#comment-17428467
]
ASF GitHub Bot commented on DISPATCH-1487:
------------------------------------------
ganeshmurthy commented on a change in pull request #1382:
URL: https://github.com/apache/qpid-dispatch/pull/1382#discussion_r728397948
##########
File path: include/qpid/dispatch/buffer.h
##########
@@ -201,6 +201,265 @@ static inline unsigned char *qd_buffer_at(const
qd_buffer_t *buf, size_t len)
void qd_buffer_list_append(qd_buffer_list_t *buflist, const uint8_t *data,
size_t len);
+#include <stdbool.h>
+
///@}
+/* descriptor for a sequence of bytes in a buffer list
+ */
+typedef struct qd_buffer_field_t qd_buffer_field_t;
+struct qd_buffer_field_t {
+ qd_buffer_t *head;
+ const uint8_t *cursor;
+ size_t length;
+};
+
+
+
+typedef struct qd_amqp_field_t qd_amqp_field_t;
+struct qd_amqp_field_t {
+ uint8_t tag;
+ uint32_t size;
+ uint32_t count;
+ qd_buffer_field_t data;
+};
+
+
+
+// copy up to n octets to dest, advance bfield by the number of octets copied
+static inline size_t qd_buffer_field_memcpy(qd_buffer_field_t *bfield, uint8_t
*dest, size_t n)
Review comment:
should the buffer field related functions reside in buffer_field.h ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Improve the parsing of message annotations
> ------------------------------------------
>
> Key: DISPATCH-1487
> URL: https://issues.apache.org/jira/browse/DISPATCH-1487
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Router Node
> Affects Versions: 1.9.0
> Reporter: Ken Giusti
> Assignee: Ken Giusti
> Priority: Major
> Fix For: 1.18.0
>
>
> ToDo: Refactor inbound MA parsing on inbound inter-router links to improve
> throughput and reduce latency.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]