[
https://issues.apache.org/jira/browse/DISPATCH-2230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430101#comment-17430101
]
ASF GitHub Bot commented on DISPATCH-2230:
------------------------------------------
ganeshmurthy opened a new pull request #1389:
URL: https://github.com/apache/qpid-dispatch/pull/1389
… it has been discarded
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Review callback action functions and fix all those that don't check the
> `discard` flag
> --------------------------------------------------------------------------------------
>
> Key: DISPATCH-2230
> URL: https://issues.apache.org/jira/browse/DISPATCH-2230
> Project: Qpid Dispatch
> Issue Type: Bug
> Affects Versions: 1.17.0
> Reporter: Jiri Daněk
> Assignee: Ganesh Murthy
> Priority: Major
> Fix For: 1.18.0
>
>
> As noted in discussion under DISPATCH-2109, there are action callback
> functions that do not check the {{discard}} flag. For example, those in
> https://github.com/apache/qpid-dispatch/blob/48d52576d5959c03b5af5c4a2f9e1d55aeeb4c36/src/router_core/route_tables.c#L360-L532.
> These action functions need to check the discard flag, and if it is set (that
> means the router is shutting down), then they need to free action parameters
> and return without doing anything.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
