[
https://issues.apache.org/jira/browse/DISPATCH-2264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17434969#comment-17434969
]
ASF GitHub Bot commented on DISPATCH-2264:
------------------------------------------
codecov-commenter commented on pull request #1397:
URL: https://github.com/apache/qpid-dispatch/pull/1397#issuecomment-953126673
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1397?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#1397](https://codecov.io/gh/apache/qpid-dispatch/pull/1397?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(ac5f195) into
[main](https://codecov.io/gh/apache/qpid-dispatch/commit/0c5015791353fd8630474e0ced17a7898c2e54c1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(0c50157) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/1397?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## main #1397 +/- ##
==========================================
+ Coverage 84.64% 84.65% +0.01%
==========================================
Files 114 114
Lines 28427 28426 -1
==========================================
+ Hits 24061 24063 +2
+ Misses 4366 4363 -3
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1397?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1397/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
| `93.52% <0.00%> (-1.30%)` | :arrow_down: |
|
[src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1397/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j)
| `82.70% <0.00%> (-0.58%)` | :arrow_down: |
|
[src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1397/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21lc3NhZ2UuYw==)
| `87.49% <0.00%> (-0.07%)` | :arrow_down: |
|
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1397/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
| `90.23% <0.00%> (-0.01%)` | :arrow_down: |
|
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1397/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
| `93.45% <0.00%> (+0.19%)` | :arrow_up: |
|
[src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1397/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j)
| `93.46% <0.00%> (+0.39%)` | :arrow_up: |
|
[src/router\_core/modules/edge\_router/edge\_mgmt.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1397/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvZWRnZV9tZ210LmM=)
| `85.14% <0.00%> (+0.99%)` | :arrow_up: |
|
[...router\_core/modules/edge\_router/link\_route\_proxy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1397/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvbGlua19yb3V0ZV9wcm94eS5j)
| `82.84% <0.00%> (+4.14%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1397?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1397?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[0c50157...ac5f195](https://codecov.io/gh/apache/qpid-dispatch/pull/1397?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> [http2] Router crash on delete of httpListener
> ----------------------------------------------
>
> Key: DISPATCH-2264
> URL: https://issues.apache.org/jira/browse/DISPATCH-2264
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Protocol Adaptors
> Affects Versions: 1.17.0
> Reporter: Ganesh Murthy
> Assignee: Ganesh Murthy
> Priority: Major
> Fix For: 1.18.0
>
>
> Add a httpListener to the router config listener like this
> {noformat}
> httpListener {
> port: 21483
> address: examples
> host: 127.0.0.1
> protocolVersion: HTTP2
> name: http-listener
> } {noformat}
> Try deleting the httpListener using qdmanage and the router will crash with
> the following backtrace
> {noformat}
> qdmanage -b 0.0.0.0:21482 DELETE --type=httpListener --name=http-listener
> {noformat}
> {noformat}
> ==2430968==ERROR: AddressSanitizer: heap-use-after-free on address
> 0x6020000036f0 at pc 0x7f05f98ec55d bp 0x7f05e60d3410 sp 0x7f05e60d2bc0
> READ of size 2 at 0x6020000036f0 thread T2
> #0 0x7f05f98ec55c (/lib64/libasan.so.6+0x5a55c)
> #1 0x7f05f98edeb5 in __interceptor_vsnprintf (/lib64/libasan.so.6+0x5beb5)
> #2 0x51d2e3 in qd_vlog_impl
> /home/gmurthy/opensource/qpid-dispatch/src/log.c:443
> #3 0x51d8c5 in qd_log_impl
> /home/gmurthy/opensource/qpid-dispatch/src/log.c:463
> #4 0x73bdae in handle_listener_event
> /home/gmurthy/opensource/qpid-dispatch/src/adaptors/http2/http2_adaptor.c:2607
> #5 0x6de966 in handle_event_with_context
> /home/gmurthy/opensource/qpid-dispatch/src/server.c:814
> #6 0x6de9e4 in do_handle_listener
> /home/gmurthy/opensource/qpid-dispatch/src/server.c:825
> #7 0x6e1443 in handle
> /home/gmurthy/opensource/qpid-dispatch/src/server.c:1024
> #8 0x6e2fde in thread_run
> /home/gmurthy/opensource/qpid-dispatch/src/server.c:1133
> #9 0x575775 in _thread_init
> /home/gmurthy/opensource/qpid-dispatch/src/posix/threading.c:172
> #10 0x7f05f98283f8 in start_thread (/lib64/libpthread.so.0+0x93f8)
> #11 0x7f05f89ce4c2 in __clone (/lib64/libc.so.6+0x1014c2)
> 0x6020000036f0 is located 0 bytes inside of 16-byte region
> [0x6020000036f0,0x602000003700)
> freed by thread T3 here:
> #0 0x7f05f993d067 in __interceptor_free (/lib64/libasan.so.6+0xab067)
> #1 0x436e43 in qd_http_free_bridge_config
> /home/gmurthy/opensource/qpid-dispatch/src/adaptors/http_common.c:93
> #2 0x4378fb in qd_http_listener_decref
> /home/gmurthy/opensource/qpid-dispatch/src/adaptors/http_common.c:233
> #3 0x73d7b9 in qd_http2_delete_listener
> /home/gmurthy/opensource/qpid-dispatch/src/adaptors/http2/http2_adaptor.c:2650
> #4 0x437164 in qd_dispatch_delete_http_listener
> /home/gmurthy/opensource/qpid-dispatch/src/adaptors/http_common.c:138
> #5 0x7f05e6f97b0f in ffi_call_unix64 (/lib64/libffi.so.6+0x6b0f)
> #6 0x7f05e58bc0bf (<unknown module>)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
